Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
diff --git a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
index fd5b933f6820bf1e3a6c713185d5776bc279cdfe..a2ce75170ba209a48736ae5d9649a8cf49ea315b 100644
--- a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
+++ b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
@@ -143,7 +143,7 @@ String AbstractPropertySetCSSStyleDeclaration::item(unsigned i) const
return "";
StylePropertySet::PropertyReference property = propertySet().propertyAt(i);
if (RuntimeEnabledFeatures::cssVariablesEnabled() && property.id() == CSSPropertyVariable)
- return toCSSCustomPropertyDeclaration(property.value())->name();
+ return toCSSCustomPropertyDeclaration(property.value()).name();
if (property.id() == CSSPropertyApplyAtRule)
return "@apply";
return getPropertyName(property.id());
@@ -303,7 +303,7 @@ StyleSheetContents* AbstractPropertySetCSSStyleDeclaration::contextStyleSheet()
bool AbstractPropertySetCSSStyleDeclaration::cssPropertyMatches(CSSPropertyID propertyID, const CSSValue* propertyValue) const
{
- return propertySet().propertyMatches(propertyID, propertyValue);
+ return propertySet().propertyMatches(propertyID, *propertyValue);
}
DEFINE_TRACE(AbstractPropertySetCSSStyleDeclaration)
« no previous file with comments | « third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp ('k') | third_party/WebKit/Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698