Make PropertyReference value() return a const CSSValue&

third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 99 matching lines @@
     bool ruleSetsCustomProperty = false;
     if (!state.style()->variables())
         return false;
     for (const auto& matchedProperties : range) {
         const StylePropertySet& properties = *matchedProperties.properties;
         unsigned propertyCount = properties.propertyCount();
         for (unsigned i = 0; i < propertyCount; ++i) {
             StylePropertySet::PropertyReference current = properties.propertyAt(i);
             if (current.id() != CSSPropertyApplyAtRule)
                 continue;
-            AtomicString name(toCSSCustomIdentValue(current.value())->value());
+            AtomicString name(toCSSCustomIdentValue(current.value()).value());
             CSSVariableData* variableData = state.style()->variables()->getVariable(name);
             if (!variableData)
                 continue;
             StylePropertySet* customPropertySet = variableData->propertySet();
             if (!customPropertySet)
                 continue;
             if (customPropertySet->findPropertyIndex(CSSPropertyVariable) != -1)
                 ruleSetsCustomProperty = true;
             state.setCustomPropertySetForApplyAtRule(name, customPropertySet);
         }
@@ skipping 1257 matching lines @@
     if (propertyWhitelistType == PropertyWhitelistCue)
         return isValidCueStyleProperty(property) && !shouldIgnoreTextTrackAuthorStyle(document);
 
     ASSERT_NOT_REACHED();
     return true;
 }
 
 // This method expands the 'all' shorthand property to longhand properties
 // and applies the expanded longhand properties.
 template <CSSPropertyPriority priority>
-void StyleResolver::applyAllProperty(StyleResolverState& state, const CSSValue* allValue, bool inheritedOnly, PropertyWhitelistType propertyWhitelistType)
+void StyleResolver::applyAllProperty(StyleResolverState& state, const CSSValue& allValue, bool inheritedOnly, PropertyWhitelistType propertyWhitelistType)
 {
     // The 'all' property doesn't apply to variables:
     // https://drafts.csswg.org/css-variables/#defining-variables
     if (priority == ResolveVariables)
         return;
 
     unsigned startCSSProperty = CSSPropertyPriorityData<priority>::first();
     unsigned endCSSProperty = CSSPropertyPriorityData<priority>::last();
 
     for (unsigned i = startCSSProperty; i <= endCSSProperty; ++i) {
@@ skipping 13 matching lines @@
             continue;
 
         if (!isPropertyInWhitelist(propertyWhitelistType, propertyId, document()))
             continue;
 
         // When hitting matched properties' cache, only inherited properties will be
         // applied.
         if (inheritedOnly && !CSSPropertyMetadata::isInheritedProperty(propertyId))
             continue;
 
-        StyleBuilder::applyProperty(propertyId, state, *allValue);
+        StyleBuilder::applyProperty(propertyId, state, allValue);
     }
 }
 
 template <CSSPropertyPriority priority>
-void StyleResolver::applyPropertiesForApplyAtRule(StyleResolverState& state, const CSSValue* value, bool isImportant, bool inheritedOnly, PropertyWhitelistType propertyWhitelistType)
+void StyleResolver::applyPropertiesForApplyAtRule(StyleResolverState& state, const CSSValue& value, bool isImportant, bool inheritedOnly, PropertyWhitelistType propertyWhitelistType)
 {
     if (!state.style()->variables())
         return;
-    const String& name = toCSSCustomIdentValue(value)->value();
+    const String& name = toCSSCustomIdentValue(value).value();
     const StylePropertySet* propertySet = state.customPropertySetForApplyAtRule(name);
     if (propertySet)
         applyProperties<priority>(state, propertySet, isImportant, inheritedOnly, propertyWhitelistType);
 }
 
 template <CSSPropertyPriority priority>
 void StyleResolver::applyProperties(StyleResolverState& state, const StylePropertySet* properties, bool isImportant, bool inheritedOnly, PropertyWhitelistType propertyWhitelistType)
 {
     unsigned propertyCount = properties->propertyCount();
     for (unsigned i = 0; i < propertyCount; ++i) {
@@ skipping 13 matching lines @@
             continue;
         }
 
         if (!isPropertyInWhitelist(propertyWhitelistType, property, document()))
             continue;
 
         if (inheritedOnly && !current.isInherited()) {
             // If the property value is explicitly inherited, we need to apply further non-inherited properties
             // as they might override the value inherited here. For this reason we don't allow declarations with
             // explicitly inherited properties to be cached.
-            ASSERT(!current.value()->isInheritedValue());
+            DCHECK(!current.value().isInheritedValue());
             continue;
         }
 
         if (!CSSPropertyPriorityData<priority>::propertyHasPriority(property))
             continue;
 
-        StyleBuilder::applyProperty(current.id(), state, *current.value());
+        StyleBuilder::applyProperty(current.id(), state, current.value());
     }
 }
 
 template <CSSPropertyPriority priority>
 void StyleResolver::applyMatchedProperties(StyleResolverState& state, const MatchedPropertiesRange& range, bool isImportant, bool inheritedOnly)
 {
     if (range.isEmpty())
         return;
 
     if (state.style()->insideLink() != NotInsideLink) {
@@ skipping 253 matching lines @@
     visitor->trace(m_siblingRuleSet);
     visitor->trace(m_uncommonAttributeRuleSet);
     visitor->trace(m_watchedSelectorsRules);
     visitor->trace(m_treeBoundaryCrossingScopes);
     visitor->trace(m_styleSharingLists);
     visitor->trace(m_pendingStyleSheets);
     visitor->trace(m_document);
 }
 
 } // namespace blink