Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RuleFeature.cpp
diff --git a/third_party/WebKit/Source/core/css/RuleFeature.cpp b/third_party/WebKit/Source/core/css/RuleFeature.cpp
index 2d49bd91e05232aa4fa39818633405c0c4290c26..5acd6a9aabe7d170e88c6fc6dc171590635db28b 100644
--- a/third_party/WebKit/Source/core/css/RuleFeature.cpp
+++ b/third_party/WebKit/Source/core/css/RuleFeature.cpp
@@ -389,12 +389,12 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r
return;
StylePropertySet::PropertyReference contentProperty = propertySet.propertyAt(propertyIndex);
- const CSSValue* contentValue = contentProperty.value();
+ const CSSValue& contentValue = contentProperty.value();
- if (!contentValue->isValueList())
+ if (!contentValue.isValueList())
return;
- for (auto& item : toCSSValueList(*contentValue)) {
+ for (auto& item : toCSSValueList(contentValue)) {
if (!item->isFunctionValue())
continue;
const CSSFunctionValue* functionValue = toCSSFunctionValue(item.get());

Powered by Google App Engine
This is Rietveld 408576698