third_party/WebKit/Source/core/css/RuleFeature.cpp - Issue 2044023005: Make PropertyReference value() return a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | third_party/WebKit/Source/core/css/StylePropertySerializer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/RuleFeature.cpp

diff --git a/third_party/WebKit/Source/core/css/RuleFeature.cpp b/third_party/WebKit/Source/core/css/RuleFeature.cpp

index 2d49bd91e05232aa4fa39818633405c0c4290c26..5acd6a9aabe7d170e88c6fc6dc171590635db28b 100644

--- a/third_party/WebKit/Source/core/css/RuleFeature.cpp

+++ b/third_party/WebKit/Source/core/css/RuleFeature.cpp

@@ -389,12 +389,12 @@ void RuleFeatureSet::updateInvalidationSetsForContentAttribute(const RuleData& r

return;

StylePropertySet::PropertyReference contentProperty = propertySet.propertyAt(propertyIndex);

- const CSSValue* contentValue = contentProperty.value();

+ const CSSValue& contentValue = contentProperty.value();

- if (!contentValue->isValueList())

+ if (!contentValue.isValueList())

return;

- for (auto& item : toCSSValueList(*contentValue)) {

+ for (auto& item : toCSSValueList(contentValue)) {

if (!item->isFunctionValue())

continue;

const CSSFunctionValue* functionValue = toCSSFunctionValue(item.get());