Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2046243002: Removed the non-const version of PropertyReference::value() (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@make_csscursorimagevalue_reresolveurl_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed the non-const version of PropertyReference::value() Removed the version of PropertyReference::value() that returns a non-const CSSValue*. This is an entirely mechanical change that is more semantically correct and safe, and also removes a FIXME in the code. BUG=526586 Committed: https://crrev.com/1e96b28ee6abefa6c151818c32bf7cda3bc669ed Cr-Commit-Position: refs/heads/master@{#406463}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
sashab
I know all the trybots are failing; they're getting patch failure because they can't apply ...
4 years, 6 months ago (2016-06-09 04:34:51 UTC) #2
sashab
Haraken ptal :)
4 years, 5 months ago (2016-07-19 03:37:32 UTC) #10
haraken
LGTM
4 years, 5 months ago (2016-07-19 19:54:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2046243002/60001
4 years, 5 months ago (2016-07-20 00:49:53 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-20 02:16:39 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 02:16:49 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 02:18:37 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1e96b28ee6abefa6c151818c32bf7cda3bc669ed
Cr-Commit-Position: refs/heads/master@{#406463}

Powered by Google App Engine
This is Rietveld 408576698