Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.h

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/StringKeyframe.h
diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.h b/third_party/WebKit/Source/core/animation/StringKeyframe.h
index 6469a52aacf4bf1e51ac50ed5167e0161625c7c2..bf7beae52b59fee6a766b5901ff24b141b97b161 100644
--- a/third_party/WebKit/Source/core/animation/StringKeyframe.h
+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.h
@@ -23,18 +23,18 @@ public:
}
void setCSSPropertyValue(CSSPropertyID, const String& value, Element*, StyleSheetContents*);
- void setCSSPropertyValue(CSSPropertyID, const CSSValue*);
+ void setCSSPropertyValue(CSSPropertyID, const CSSValue&);
void setPresentationAttributeValue(CSSPropertyID, const String& value, Element*, StyleSheetContents*);
void setSVGAttributeValue(const QualifiedName&, const String& value);
- const CSSValue* cssPropertyValue(CSSPropertyID property) const
+ const CSSValue& cssPropertyValue(CSSPropertyID property) const
{
int index = m_cssPropertyMap->findPropertyIndex(property);
RELEASE_ASSERT(index >= 0);
return m_cssPropertyMap->propertyAt(static_cast<unsigned>(index)).value();
}
- const CSSValue* presentationAttributeValue(CSSPropertyID property) const
+ const CSSValue& presentationAttributeValue(CSSPropertyID property) const
{
int index = m_presentationAttributeMap->findPropertyIndex(property);
RELEASE_ASSERT(index >= 0);

Powered by Google App Engine
This is Rietveld 408576698