third_party/WebKit/Source/core/animation/StringKeyframe.h - Issue 2044023005: Make PropertyReference value() return a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.h

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp ('k') | third_party/WebKit/Source/core/animation/StringKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/StringKeyframe.h

diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.h b/third_party/WebKit/Source/core/animation/StringKeyframe.h

index 6469a52aacf4bf1e51ac50ed5167e0161625c7c2..bf7beae52b59fee6a766b5901ff24b141b97b161 100644

--- a/third_party/WebKit/Source/core/animation/StringKeyframe.h

+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.h

@@ -23,18 +23,18 @@ public:

}

void setCSSPropertyValue(CSSPropertyID, const String& value, Element*, StyleSheetContents*);

- void setCSSPropertyValue(CSSPropertyID, const CSSValue*);

+ void setCSSPropertyValue(CSSPropertyID, const CSSValue&);

void setPresentationAttributeValue(CSSPropertyID, const String& value, Element*, StyleSheetContents*);

void setSVGAttributeValue(const QualifiedName&, const String& value);

- const CSSValue* cssPropertyValue(CSSPropertyID property) const

+ const CSSValue& cssPropertyValue(CSSPropertyID property) const

{

int index = m_cssPropertyMap->findPropertyIndex(property);

RELEASE_ASSERT(index >= 0);

return m_cssPropertyMap->propertyAt(static_cast<unsigned>(index)).value();

}

- const CSSValue* presentationAttributeValue(CSSPropertyID property) const

+ const CSSValue& presentationAttributeValue(CSSPropertyID property) const

{

int index = m_presentationAttributeMap->findPropertyIndex(property);

RELEASE_ASSERT(index >= 0);