Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
diff --git a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
index dd15534ed971e48d5e599c4844bdee67549cc715..bb49fdcb73eba225d796584313a83c89dc14e4c5 100644
--- a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
+++ b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
@@ -50,7 +50,7 @@ StylePropertySerializer::StylePropertySetForSerializer::StylePropertySetForSeria
continue;
if (static_cast<unsigned>(m_allIndex) >= i)
continue;
- if (property.value()->equals(*allProperty.value())
+ if (property.value().equals(allProperty.value())
&& property.isImportant() == allProperty.isImportant())
continue;
m_needToExpandAll = true;
@@ -87,7 +87,7 @@ StylePropertySerializer::PropertyValueForSerializer StylePropertySerializer::Sty
}
StylePropertySet::PropertyReference property = m_propertySet->propertyAt(m_allIndex);
- return StylePropertySerializer::PropertyValueForSerializer(propertyID, property.value(), property.isImportant());
+ return StylePropertySerializer::PropertyValueForSerializer(propertyID, &property.value(), property.isImportant());
}
bool StylePropertySerializer::StylePropertySetForSerializer::shouldProcessPropertyAt(unsigned index) const
« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySerializer.h ('k') | third_party/WebKit/Source/core/css/StylePropertySet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698