third_party/WebKit/Source/core/css/StylePropertySerializer.cpp - Issue 2044023005: Make PropertyReference value() return a const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/StylePropertySerializer.h ('k') | third_party/WebKit/Source/core/css/StylePropertySet.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

diff --git a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

index dd15534ed971e48d5e599c4844bdee67549cc715..bb49fdcb73eba225d796584313a83c89dc14e4c5 100644

--- a/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

+++ b/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

@@ -50,7 +50,7 @@ StylePropertySerializer::StylePropertySetForSerializer::StylePropertySetForSeria

continue;

if (static_cast<unsigned>(m_allIndex) >= i)

continue;

- if (property.value()->equals(*allProperty.value())

+ if (property.value().equals(allProperty.value())

&& property.isImportant() == allProperty.isImportant())

continue;

m_needToExpandAll = true;

@@ -87,7 +87,7 @@ StylePropertySerializer::PropertyValueForSerializer StylePropertySerializer::Sty

}

StylePropertySet::PropertyReference property = m_propertySet->propertyAt(m_allIndex);

- return StylePropertySerializer::PropertyValueForSerializer(propertyID, property.value(), property.isImportant());

+ return StylePropertySerializer::PropertyValueForSerializer(propertyID, &property.value(), property.isImportant());

}

bool StylePropertySerializer::StylePropertySetForSerializer::shouldProcessPropertyAt(unsigned index) const