Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0 Cr-Commit-Position: refs/heads/master@{#397758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -71 lines) Patch
M components/flags_ui/flags_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/flags_ui/pref_service_flags_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/json_schema/json_schema_validator_unittest_base.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M components/policy/core/browser/configuration_policy_pref_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/policy/core/common/schema_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/prefs/pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/default_search_pref_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ssl_config/ssl_config_service_manager_pref_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/syncable_prefs/pref_model_associator_unittest.cc View 11 chunks +22 lines, -22 lines 0 comments Download
M components/syncable_prefs/pref_service_syncable_unittest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M components/translate/core/browser/translate_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_matcher/url_matcher_factory_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/version_ui/version_handler_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:18:18 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-03 12:46:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030833003/1
4 years, 6 months ago (2016-06-03 17:33:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:18:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:20:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58241a814b2134be24c06ad0f8791cb038dc26f0
Cr-Commit-Position: refs/heads/master@{#397758}

Powered by Google App Engine
This is Rietveld 408576698