Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc
diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
index b00b46ffa2a640cdcd05acb39efc4522db62505c..14d71c655e5de9e1dee59f7ec3e9ac233f91c5b5 100644
--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc
@@ -57,8 +57,8 @@ TEST_F(ConfigurationPolicyPrefStoreListTest, GetDefault) {
TEST_F(ConfigurationPolicyPrefStoreListTest, SetValue) {
std::unique_ptr<base::ListValue> in_value(new base::ListValue());
- in_value->Append(new base::StringValue("test1"));
- in_value->Append(new base::StringValue("test2,"));
+ in_value->AppendString("test1");
+ in_value->AppendString("test2,");
PolicyMap policy;
policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD, in_value->CreateDeepCopy(), nullptr);
« no previous file with comments | « components/json_schema/json_schema_validator_unittest_base.cc ('k') | components/policy/core/common/schema_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698