components/translate/core/browser/translate_prefs.cc - Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_prefs.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/syncable_prefs/pref_service_syncable_unittest.cc ('k') | components/url_matcher/url_matcher_factory_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_prefs.cc

diff --git a/components/translate/core/browser/translate_prefs.cc b/components/translate/core/browser/translate_prefs.cc

index d5ca4502ac8c9f61a3b507b1a3845b169e18d708..83c7cc8e7ecc9253e3352199b870f05c4c1df94a 100644

--- a/components/translate/core/browser/translate_prefs.cc

+++ b/components/translate/core/browser/translate_prefs.cc

@@ -540,7 +540,7 @@ void TranslatePrefs::BlacklistValue(const char* pref_id,

NOTREACHED() << "Unregistered translate blacklist pref";

return;

}

- blacklist->Append(new base::StringValue(value));

+ blacklist->AppendString(value);

}