Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: components/version_ui/version_handler_helper.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/url_matcher/url_matcher_factory_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_ui/version_handler_helper.cc
diff --git a/components/version_ui/version_handler_helper.cc b/components/version_ui/version_handler_helper.cc
index cc4bd94adb169db275d9e8f2e420bb5863c30b10..b24c03c6f76cf85979fb89867df7e4e0b49e97fe 100644
--- a/components/version_ui/version_handler_helper.cc
+++ b/components/version_ui/version_handler_helper.cc
@@ -36,7 +36,7 @@ std::unique_ptr<base::Value> GetVariationsList() {
std::unique_ptr<base::ListValue> variations_list(new base::ListValue);
for (std::vector<std::string>::const_iterator it = variations.begin();
it != variations.end(); ++it) {
- variations_list->Append(new base::StringValue(*it));
+ variations_list->AppendString(*it);
}
return std::move(variations_list);
« no previous file with comments | « components/url_matcher/url_matcher_factory_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698