components/ssl_config/ssl_config_service_manager_pref_unittest.cc - Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ssl_config/ssl_config_service_manager_pref_unittest.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/default_search_pref_test_util.cc ('k') | components/syncable_prefs/pref_model_associator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ssl_config/ssl_config_service_manager_pref_unittest.cc

diff --git a/components/ssl_config/ssl_config_service_manager_pref_unittest.cc b/components/ssl_config/ssl_config_service_manager_pref_unittest.cc

index ff5c2e1c325621ef38e01987d972e56f22f4d599..07aaef88f48dbed2b72f3e8318ce3ea3400e32f3 100644

--- a/components/ssl_config/ssl_config_service_manager_pref_unittest.cc

+++ b/components/ssl_config/ssl_config_service_manager_pref_unittest.cc

@@ -65,8 +65,8 @@ TEST_F(SSLConfigServiceManagerPrefTest, GoodDisabledCipherSuites) {

EXPECT_TRUE(old_config.disabled_cipher_suites.empty());

base::ListValue* list_value = new base::ListValue();

- list_value->Append(new base::StringValue("0x0004"));

- list_value->Append(new base::StringValue("0x0005"));

+ list_value->AppendString("0x0004");

+ list_value->AppendString("0x0005");

local_state.SetUserPref(ssl_config::prefs::kCipherSuiteBlacklist, list_value);

// Pump the message loop to notify the SSLConfigServiceManagerPref that the

@@ -101,10 +101,10 @@ TEST_F(SSLConfigServiceManagerPrefTest, BadDisabledCipherSuites) {

EXPECT_TRUE(old_config.disabled_cipher_suites.empty());

base::ListValue* list_value = new base::ListValue();

- list_value->Append(new base::StringValue("0x0004"));

- list_value->Append(new base::StringValue("TLS_NOT_WITH_A_CIPHER_SUITE"));

- list_value->Append(new base::StringValue("0x0005"));

- list_value->Append(new base::StringValue("0xBEEFY"));

+ list_value->AppendString("0x0004");

+ list_value->AppendString("TLS_NOT_WITH_A_CIPHER_SUITE");

+ list_value->AppendString("0x0005");

+ list_value->AppendString("0xBEEFY");

local_state.SetUserPref(ssl_config::prefs::kCipherSuiteBlacklist, list_value);

// Pump the message loop to notify the SSLConfigServiceManagerPref that the