Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: components/flags_ui/flags_state.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/flags_ui/pref_service_flags_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/flags_ui/flags_state.cc
diff --git a/components/flags_ui/flags_state.cc b/components/flags_ui/flags_state.cc
index 58425f4cffb703b1cb0d49af33cb75e990e0a6e9..43185bc7c90a13dec1fe79c3f58ad6657718e10c 100644
--- a/components/flags_ui/flags_state.cc
+++ b/components/flags_ui/flags_state.cc
@@ -82,7 +82,7 @@ const struct {
void AddOsStrings(unsigned bitmask, base::ListValue* list) {
for (size_t i = 0; i < arraysize(kBitsToOs); ++i) {
if (bitmask & kBitsToOs[i].bit)
- list->Append(new base::StringValue(kBitsToOs[i].name));
+ list->AppendString(kBitsToOs[i].name);
}
}
« no previous file with comments | « no previous file | components/flags_ui/pref_service_flags_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698