components/prefs/pref_service_unittest.cc - Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/prefs/pref_service_unittest.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/schema_unittest.cc ('k') | components/search_engines/default_search_pref_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/prefs/pref_service_unittest.cc

diff --git a/components/prefs/pref_service_unittest.cc b/components/prefs/pref_service_unittest.cc

index ea9577726a9fce34d80fca28dece73ad0726e8a2..373c01bcb3f3c2b37ef1966362f100936e61f12a 100644

--- a/components/prefs/pref_service_unittest.cc

+++ b/components/prefs/pref_service_unittest.cc

@@ -414,7 +414,7 @@ TEST_F(PrefServiceSetValueTest, SetListValue) {

Mock::VerifyAndClearExpectations(&observer_);

base::ListValue new_value;

- new_value.Append(new base::StringValue(kValue));

+ new_value.AppendString(kValue);

observer_.Expect(kName, &new_value);

prefs_.Set(kName, new_value);

Mock::VerifyAndClearExpectations(&observer_);

« no previous file with comments | « components/policy/core/common/schema_unittest.cc ('k') | components/search_engines/default_search_pref_test_util.cc » ('j') | no next file with comments »