Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: components/prefs/pref_service_unittest.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 prefs_.registry()->RegisterListPref(kName); 407 prefs_.registry()->RegisterListPref(kName);
408 PrefChangeRegistrar registrar; 408 PrefChangeRegistrar registrar;
409 registrar.Init(&prefs_); 409 registrar.Init(&prefs_);
410 registrar.Add(kName, observer_.GetCallback()); 410 registrar.Add(kName, observer_.GetCallback());
411 411
412 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0); 412 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
413 prefs_.RemoveUserPref(kName); 413 prefs_.RemoveUserPref(kName);
414 Mock::VerifyAndClearExpectations(&observer_); 414 Mock::VerifyAndClearExpectations(&observer_);
415 415
416 base::ListValue new_value; 416 base::ListValue new_value;
417 new_value.Append(new base::StringValue(kValue)); 417 new_value.AppendString(kValue);
418 observer_.Expect(kName, &new_value); 418 observer_.Expect(kName, &new_value);
419 prefs_.Set(kName, new_value); 419 prefs_.Set(kName, new_value);
420 Mock::VerifyAndClearExpectations(&observer_); 420 Mock::VerifyAndClearExpectations(&observer_);
421 421
422 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0); 422 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
423 prefs_.Set(kName, new_value); 423 prefs_.Set(kName, new_value);
424 Mock::VerifyAndClearExpectations(&observer_); 424 Mock::VerifyAndClearExpectations(&observer_);
425 425
426 base::ListValue empty; 426 base::ListValue empty;
427 observer_.Expect(kName, &empty); 427 observer_.Expect(kName, &empty);
428 prefs_.Set(kName, empty); 428 prefs_.Set(kName, empty);
429 Mock::VerifyAndClearExpectations(&observer_); 429 Mock::VerifyAndClearExpectations(&observer_);
430 } 430 }
OLDNEW
« no previous file with comments | « components/policy/core/common/schema_unittest.cc ('k') | components/search_engines/default_search_pref_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698