components/search_engines/default_search_pref_test_util.cc - Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/default_search_pref_test_util.cc

Issue 2030833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/prefs/pref_service_unittest.cc ('k') | components/ssl_config/ssl_config_service_manager_pref_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines/default_search_pref_test_util.cc

diff --git a/components/search_engines/default_search_pref_test_util.cc b/components/search_engines/default_search_pref_test_util.cc

index 3fdf4807725912d9ce2a6bff9d90c686899fdb1a..193ab8f1452e2ebf13c957902e8c785601eec2b1 100644

--- a/components/search_engines/default_search_pref_test_util.cc

+++ b/components/search_engines/default_search_pref_test_util.cc

@@ -49,7 +49,7 @@ DefaultSearchPrefTestUtil::CreateDefaultSearchPreferenceValue(

std::unique_ptr<base::ListValue> alternate_url_list(new base::ListValue());

if (!alternate_url.empty())

- alternate_url_list->Append(new base::StringValue(alternate_url));

+ alternate_url_list->AppendString(alternate_url);

value->Set(DefaultSearchManager::kAlternateURLs,

alternate_url_list.release());

return value;

« no previous file with comments | « components/prefs/pref_service_unittest.cc ('k') | components/ssl_config/ssl_config_service_manager_pref_unittest.cc » ('j') | no next file with comments »