Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components

components/json_schema/json_schema_validator_unittest_base.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/json_schema/json_schema_validator_unittest_base.h"
 
 #include <cfloat>
 #include <cmath>
 #include <limits>
 #include <memory>
@@ skipping 367 matching lines @@
                      JSONSchemaValidator::kUnknownTypeReference,
                      "NegativeInt"));
 }
 
 void JSONSchemaValidatorTestBase::TestArrayTuple() {
   std::unique_ptr<base::DictionaryValue> schema(
       LoadDictionary("array_tuple_schema.json"));
   ASSERT_TRUE(schema.get());
 
   std::unique_ptr<base::ListValue> instance(new base::ListValue());
-  instance->Append(new base::StringValue("42"));
-  instance->Append(new base::FundamentalValue(42));
+  instance->AppendString("42");
+  instance->AppendInteger(42);
 
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
 
-  instance->Append(new base::StringValue("anything"));
+  instance->AppendString("anything");
   ExpectNotValid(TEST_SOURCE,
                  instance.get(),
                  schema.get(),
                  NULL,
                  std::string(),
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kArrayMaxItems, "2"));
 
   instance->Remove(1, NULL);
   instance->Remove(1, NULL);
   ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "1",
                  JSONSchemaValidator::kArrayItemRequired);
 
   instance->Set(0, new base::FundamentalValue(42));
-  instance->Append(new base::FundamentalValue(42));
+  instance->AppendInteger(42);
   ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "0",
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kInvalidType,
                      schema::kString,
                      schema::kInteger));
 
   base::DictionaryValue* additional_properties = new base::DictionaryValue();
   additional_properties->SetString(schema::kType, schema::kAny);
   schema->Set(schema::kAdditionalProperties, additional_properties);
   instance->Set(0, new base::StringValue("42"));
-  instance->Append(new base::StringValue("anything"));
+  instance->AppendString("anything");
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
   instance->Set(2, new base::ListValue());
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
 
   additional_properties->SetString(schema::kType, schema::kBoolean);
   ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "2",
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kInvalidType,
                      schema::kBoolean,
                      schema::kArray));
@@ skipping 20 matching lines @@
 }
 
 void JSONSchemaValidatorTestBase::TestArrayNonTuple() {
   std::unique_ptr<base::DictionaryValue> schema(new base::DictionaryValue());
   schema->SetString(schema::kType, schema::kArray);
   schema->SetString("items.type", schema::kString);
   schema->SetInteger(schema::kMinItems, 2);
   schema->SetInteger(schema::kMaxItems, 3);
 
   std::unique_ptr<base::ListValue> instance(new base::ListValue());
-  instance->Append(new base::StringValue("x"));
-  instance->Append(new base::StringValue("x"));
+  instance->AppendString("x");
+  instance->AppendString("x");
 
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
-  instance->Append(new base::StringValue("x"));
+  instance->AppendString("x");
   ExpectValid(TEST_SOURCE, instance.get(), schema.get(), NULL);
 
-  instance->Append(new base::StringValue("x"));
+  instance->AppendString("x");
   ExpectNotValid(TEST_SOURCE,
                  instance.get(),
                  schema.get(),
                  NULL,
                  std::string(),
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kArrayMaxItems, "3"));
   instance->Remove(1, NULL);
   instance->Remove(1, NULL);
   instance->Remove(1, NULL);
   ExpectNotValid(TEST_SOURCE,
                  instance.get(),
                  schema.get(),
                  NULL,
                  std::string(),
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kArrayMinItems, "2"));
 
   instance->Remove(1, NULL);
-  instance->Append(new base::FundamentalValue(42));
+  instance->AppendInteger(42);
   ExpectNotValid(TEST_SOURCE, instance.get(), schema.get(), NULL, "1",
                  JSONSchemaValidator::FormatErrorMessage(
                      JSONSchemaValidator::kInvalidType,
                      schema::kString,
                      schema::kInteger));
 }
 
 void JSONSchemaValidatorTestBase::TestString() {
   std::unique_ptr<base::DictionaryValue> schema(new base::DictionaryValue());
   schema->SetString(schema::kType, schema::kString);
@@ skipping 259 matching lines @@
                                               schema::kInteger));
 
   schema->SetString(schema::kType, schema::kNull);
   ExpectNotValid(
       TEST_SOURCE,
       std::unique_ptr<base::Value>(new base::FundamentalValue(false)).get(),
       schema.get(), NULL, std::string(),
       JSONSchemaValidator::FormatErrorMessage(JSONSchemaValidator::kInvalidType,
                                               schema::kNull, schema::kBoolean));
 }