Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //components

components/url_matcher/url_matcher_factory_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/url_matcher/url_matcher_factory.h"
 
 #include <stddef.h>
 
 #include "base/format_macros.h"
 #include "base/macros.h"
@@ skipping 32 matching lines @@
   // Valid values:
   // {
   //   "port_range": [80, [1000, 1010]],
   //   "schemes": ["http"],
   //   "hostSuffix": "example.com"
   //   "hostPrefix": "www"
   // }
 
   // Port range: Allow 80;1000-1010.
   base::ListValue* port_range = new base::ListValue();
-  port_range->Append(new base::FundamentalValue(1000));
-  port_range->Append(new base::FundamentalValue(1010));
+  port_range->AppendInteger(1000);
+  port_range->AppendInteger(1010);
   base::ListValue* port_ranges = new base::ListValue();
-  port_ranges->Append(new base::FundamentalValue(80));
+  port_ranges->AppendInteger(80);
   port_ranges->Append(port_range);
 
   base::ListValue* scheme_list = new base::ListValue();
-  scheme_list->Append(new base::StringValue("http"));
+  scheme_list->AppendString("http");
 
   base::DictionaryValue valid_condition;
   valid_condition.SetString(keys::kHostSuffixKey, "example.com");
   valid_condition.SetString(keys::kHostPrefixKey, "www");
   valid_condition.Set(keys::kPortsKey, port_ranges);
   valid_condition.Set(keys::kSchemesKey, scheme_list);
 
   // Test wrong condition name passed.
   error.clear();
   result = URLMatcherFactory::CreateFromURLFilterDictionary(
@@ skipping 61 matching lines @@
   // {"hostPrefix": "WWw."}
   base::DictionaryValue invalid_condition3;
   invalid_condition3.SetString(keys::kHostPrefixKey, "WWw.");
 
   // {"hostEquals": "WWW.example.Com"}
   base::DictionaryValue invalid_condition4;
   invalid_condition4.SetString(keys::kHostEqualsKey, "WWW.example.Com");
 
   // {"scheme": ["HTTP"]}
   base::ListValue* scheme_list = new base::ListValue();
-  scheme_list->Append(new base::StringValue("HTTP"));
+  scheme_list->AppendString("HTTP");
   base::DictionaryValue invalid_condition5;
   invalid_condition5.Set(keys::kSchemesKey, scheme_list);
 
   const base::DictionaryValue* invalid_conditions[] = {
     &invalid_condition1,
     &invalid_condition2,
     &invalid_condition3,
     &invalid_condition4,
     &invalid_condition5
   };
@@ skipping 72 matching lines @@
   CheckCondition(expected_value_, OK);
   CheckCondition(incorrect_case_value_, expected_result_for_wrong_case_);
 }
 
 void UrlConditionCaseTest::CheckCondition(
     const std::string& value,
     UrlConditionCaseTest::ResultType expected_result) const {
   base::DictionaryValue condition;
   if (use_list_of_strings_) {
     base::ListValue* list = new base::ListValue();
-    list->Append(new base::StringValue(value));
+    list->AppendString(value);
     condition.SetWithoutPathExpansion(condition_key_, list);
   } else {
     condition.SetStringWithoutPathExpansion(condition_key_, value);
   }
 
   URLMatcher matcher;
   std::string error;
   scoped_refptr<URLMatcherConditionSet> result;
 
   result = URLMatcherFactory::CreateFromURLFilterDictionary(
@@ skipping 86 matching lines @@
                          kIsUrlCaseSensitive, kIsUrlLowerCaseEnforced, url),
   };
 
   for (size_t i = 0; i < arraysize(case_tests); ++i) {
     SCOPED_TRACE(base::StringPrintf("Iteration: %" PRIuS, i));
     case_tests[i].Test();
   }
 }
 
 }  // namespace url_matcher