Fix some TODO(GYP) in the GN build.

Fix some TODO(GYP) in the GN build.

BUG=

Committed: https://crrev.com/eb7dc65850d9e76836e2b75d315b6e3bb69753ec
Cr-Commit-Position: refs/heads/master@{#395504}

[brettw, 2016-05-23 21:06:47]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 21:07:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001323002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001323002/1

[commit-bot: I haz the power, 2016-05-23 21:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 21:53:41]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[brettw, 2016-05-23 22:06:23]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-05-23 22:06:24]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-05-23 22:06:26]

See comments added on patch set 1.

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn#oldcode797
BUILD.gn:797: "//ui/resources:repack_ui_test_mac_locale_pack",
This is referenced organically now so this reference is not needed.

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn#newcode184
BUILD.gn:184: "//sync/tools:sync_client",
Moved from below (compiled on more target types now)

https://codereview.chromium.org/2001323002/diff/20001/sync/tools/BUILD.gn
File sync/tools/BUILD.gn (right):

https://codereview.chromium.org/2001323002/diff/20001/sync/tools/BUILD.gn#new...
sync/tools/BUILD.gn:8: if (!is_ios && !is_android && !is_chromecast) {
This matches the condition in src/BUILD.gn.

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/BUILD.gn:85: ## TODO(GYP) : gn does not yet support
use_system_icu.
use_system_icu isn't required, and if we add it it should be integrated
differently than this.

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/config.gni (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/config.gni:55: # TODO(GYP) this should also be set
when release_valgrind_build is set,
Valgrind is gone.

https://codereview.chromium.org/2001323002/diff/20001/third_party/cacheinvali...
File third_party/cacheinvalidation/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/cacheinvali...
third_party/cacheinvalidation/BUILD.gn:117: # TODO(GYP) Test isolation stuff.
There are some conditions in GYP about test_isolation_mode. I assume since our
Android build works, this isn't required, and I don't know what it means.

https://codereview.chromium.org/2001323002/diff/20001/third_party/libjingle/B...
File third_party/libjingle/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/libjingle/B...
third_party/libjingle/BUILD.gn:57: # TODO(GYP): Port is_win blocks.
The only missing Windows block disables some warnings. Since we don't see those
warnings, the disabling no longer seems to be necessary.

https://codereview.chromium.org/2001323002/diff/20001/third_party/libjingle/B...
third_party/libjingle/BUILD.gn:439: # TODO(GYP): Port libjingle.gyp's
enable_webrtc condition block.
This is the block above.

https://codereview.chromium.org/2001323002/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/ui/gl/BUILD.gn#oldcode173
ui/gl/BUILD.gn:173: deps += [ "//third_party/mesa:osmesa" ]
This doesn't seem to be present in GYP at all and looks suspicious to me.

[brettw, 2016-05-23 22:06:26]

See comments added on patch set 1.

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn
File BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn#oldcode797
BUILD.gn:797: "//ui/resources:repack_ui_test_mac_locale_pack",
This is referenced organically now so this reference is not needed.

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2001323002/diff/20001/BUILD.gn#newcode184
BUILD.gn:184: "//sync/tools:sync_client",
Moved from below (compiled on more target types now)

https://codereview.chromium.org/2001323002/diff/20001/sync/tools/BUILD.gn
File sync/tools/BUILD.gn (right):

https://codereview.chromium.org/2001323002/diff/20001/sync/tools/BUILD.gn#new...
sync/tools/BUILD.gn:8: if (!is_ios && !is_android && !is_chromecast) {
This matches the condition in src/BUILD.gn.

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/BUILD.gn:85: ## TODO(GYP) : gn does not yet support
use_system_icu.
use_system_icu isn't required, and if we add it it should be integrated
differently than this.

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/config.gni (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/config.gni:55: # TODO(GYP) this should also be set
when release_valgrind_build is set,
Valgrind is gone.

https://codereview.chromium.org/2001323002/diff/20001/third_party/cacheinvali...
File third_party/cacheinvalidation/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/cacheinvali...
third_party/cacheinvalidation/BUILD.gn:117: # TODO(GYP) Test isolation stuff.
There are some conditions in GYP about test_isolation_mode. I assume since our
Android build works, this isn't required, and I don't know what it means.

https://codereview.chromium.org/2001323002/diff/20001/third_party/libjingle/B...
File third_party/libjingle/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/third_party/libjingle/B...
third_party/libjingle/BUILD.gn:57: # TODO(GYP): Port is_win blocks.
The only missing Windows block disables some warnings. Since we don't see those
warnings, the disabling no longer seems to be necessary.

https://codereview.chromium.org/2001323002/diff/20001/third_party/libjingle/B...
third_party/libjingle/BUILD.gn:439: # TODO(GYP): Port libjingle.gyp's
enable_webrtc condition block.
This is the block above.

https://codereview.chromium.org/2001323002/diff/20001/ui/gl/BUILD.gn
File ui/gl/BUILD.gn (left):

https://codereview.chromium.org/2001323002/diff/20001/ui/gl/BUILD.gn#oldcode173
ui/gl/BUILD.gn:173: deps += [ "//third_party/mesa:osmesa" ]
This doesn't seem to be present in GYP at all and looks suspicious to me.

[brettw, 2016-05-23 22:06:30]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 22:06:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001323002/40001

[commit-bot: I haz the power, 2016-05-23 22:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 22:12:04]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dirk Pranke, 2016-05-23 22:51:59]

lgtm

[brettw, 2016-05-23 23:52:12]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-05-23 23:52:15]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-05-23 23:52:18]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-05-23 23:52:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2001323002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-23 23:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001323002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001323002/60001

[commit-bot: I haz the power, 2016-05-24 01:19:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-24 01:22:04]

Description was changed from

==========
Fix some TODO(GYP) in the GN build.

BUG=
==========

to

==========
Fix some TODO(GYP) in the GN build.

BUG=

Committed: https://crrev.com/eb7dc65850d9e76836e2b75d315b6e3bb69753ec
Cr-Commit-Position: refs/heads/master@{#395504}
==========

[commit-bot: I haz the power, 2016-05-24 01:22:05]

Patchset 4 (id:??) landed as
https://crrev.com/eb7dc65850d9e76836e2b75d315b6e3bb69753ec
Cr-Commit-Position: refs/heads/master@{#395504}