third_party/WebKit/Source/BUILD.gn - Issue 2001323002: Fix some TODO(GYP) in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/BUILD.gn

diff --git a/third_party/WebKit/Source/BUILD.gn b/third_party/WebKit/Source/BUILD.gn

index 1f316a415d7bde43c25adaf7be63eb979bf0977c..6ecca3e43d562ea0ea3ab442cef3b634150e2a46 100644

--- a/third_party/WebKit/Source/BUILD.gn

+++ b/third_party/WebKit/Source/BUILD.gn

@@ -81,11 +81,6 @@ config("config") {

"blink-gc-plugin",

]

}

- ## TODO(GYP) : gn does not yet support use_system_icu.

- #if (use_system_icu) {

- # defines += [ "USING_SYSTEM_ICU" ]

- #}

}

# The follow configs apply to all targets except for unit tests, which rely on

« no previous file with comments | « testing/test.gni ('k') | third_party/WebKit/Source/config.gni » ('j') | no next file with comments »