Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: third_party/WebKit/Source/config.gni

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//third_party/WebKit/public/features.gni") 6 import("//third_party/WebKit/public/features.gni")
7 7
8 if (is_android) { 8 if (is_android) {
9 import("//build/config/android/config.gni") 9 import("//build/config/android/config.gni")
10 } 10 }
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 use_concatenated_impulse_responses = true 45 use_concatenated_impulse_responses = true
46 46
47 # feature_defines_list --------------------------------------------------------- 47 # feature_defines_list ---------------------------------------------------------
48 48
49 feature_defines_list = [ 49 feature_defines_list = [
50 "ENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0", 50 "ENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0",
51 "ENABLE_OILPAN=1", 51 "ENABLE_OILPAN=1",
52 ] 52 ]
53 53
54 if (is_debug) { 54 if (is_debug) {
55 # TODO(GYP) this should also be set when release_valgrind_build is set,
brettw 2016/05/23 22:06:26 Valgrind is gone.
56 # but we don't have that flag in the GN build yet.
57 feature_defines_list += [ "WTF_USE_DYNAMIC_ANNOTATIONS=1" ] 55 feature_defines_list += [ "WTF_USE_DYNAMIC_ANNOTATIONS=1" ]
58 } 56 }
59 57
60 if (use_concatenated_impulse_responses) { 58 if (use_concatenated_impulse_responses) {
61 feature_defines_list += [ "WTF_USE_CONCATENATED_IMPULSE_RESPONSES=1" ] 59 feature_defines_list += [ "WTF_USE_CONCATENATED_IMPULSE_RESPONSES=1" ]
62 } 60 }
63 61
64 if (use_low_quality_image_interpolation) { 62 if (use_low_quality_image_interpolation) {
65 feature_defines_list += [ "WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION=1" ] 63 feature_defines_list += [ "WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION=1" ]
66 } 64 }
(...skipping 21 matching lines...) Expand all
88 } 86 }
89 87
90 # feature_defines_string ------------------------------------------------------- 88 # feature_defines_string -------------------------------------------------------
91 89
92 # Convert the list to a space-separated string for passing to scripts. 90 # Convert the list to a space-separated string for passing to scripts.
93 # This would be the equivalent of passing '<(feature_defines)' in GYP. 91 # This would be the equivalent of passing '<(feature_defines)' in GYP.
94 feature_defines_string = 92 feature_defines_string =
95 exec_script("build/gn_list_to_space_separated_string.py", 93 exec_script("build/gn_list_to_space_separated_string.py",
96 feature_defines_list, 94 feature_defines_list,
97 "trim string") 95 "trim string")
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698