Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: sync/tools/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | testing/test.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/tools/BUILD.gn
diff --git a/sync/tools/BUILD.gn b/sync/tools/BUILD.gn
index 93c275f04d6fb265413c8c01f5dfc4ff5ea8b8af..102584241dfbd14576bd14db9059e30b6cd37c8e 100644
--- a/sync/tools/BUILD.gn
+++ b/sync/tools/BUILD.gn
@@ -4,61 +4,54 @@
import("//testing/test.gni")
-if (is_linux && !is_chromeos) {
- # TODO(GYP): Figure out which of these work and are needed on other platforms.
- source_set("common") {
- testonly = true
-
- sources = [
- "null_invalidation_state_tracker.cc",
- "null_invalidation_state_tracker.h",
- ]
-
- deps = [
- "//base",
- "//components/invalidation/impl",
- "//components/sync_driver",
- "//sync",
- ]
- }
-
- test("sync_listen_notifications") {
- sources = [
- "sync_listen_notifications.cc",
- ]
-
- defines = [ "SYNC_TEST" ]
-
- deps = [
- ":common",
- "//base",
- "//components/invalidation/impl",
- "//components/sync_driver",
- "//jingle:notifier",
- "//net",
- "//net:test_support",
- "//sync",
- "//sync:test_support_sync_core",
- ]
- }
-
- test("sync_client") {
- sources = [
- "sync_client.cc",
- ]
+source_set("common") {
+ testonly = true
+
+ sources = [
+ "null_invalidation_state_tracker.cc",
+ "null_invalidation_state_tracker.h",
+ ]
+
+ deps = [
+ "//base",
+ "//components/invalidation/impl",
+ "//components/sync_driver",
+ "//sync",
+ ]
+}
- defines = [ "SYNC_TEST" ]
+test("sync_listen_notifications") {
+ sources = [
+ "sync_listen_notifications.cc",
+ ]
+
+ defines = [ "SYNC_TEST" ]
+
+ deps = [
+ ":common",
+ "//base",
+ "//components/invalidation/impl",
+ "//components/sync_driver",
+ "//jingle:notifier",
+ "//net:test_support",
+ "//sync:test_support_sync_core",
+ ]
+}
- deps = [
- ":common",
- "//base",
- "//components/invalidation/impl",
- "//components/sync_driver",
- "//jingle:notifier",
- "//net",
- "//net:test_support",
- "//sync",
- "//sync:test_support_sync_core",
- ]
- }
+test("sync_client") {
+ sources = [
+ "sync_client.cc",
+ ]
+
+ defines = [ "SYNC_TEST" ]
+
+ deps = [
+ ":common",
+ "//base",
+ "//components/invalidation/impl",
+ "//components/sync_driver",
+ "//jingle:notifier",
+ "//net:test_support",
+ "//sync:test_support_sync_core",
+ ]
}
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | testing/test.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698