Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | sync/tools/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 "//ppapi/examples/scaling", 174 "//ppapi/examples/scaling",
175 "//ppapi/examples/scripting", 175 "//ppapi/examples/scripting",
176 "//ppapi/examples/stub", 176 "//ppapi/examples/stub",
177 "//ppapi/examples/threading", 177 "//ppapi/examples/threading",
178 "//ppapi/examples/url_loader", 178 "//ppapi/examples/url_loader",
179 "//ppapi/examples/video_capture", 179 "//ppapi/examples/video_capture",
180 "//ppapi/examples/video_decode", 180 "//ppapi/examples/video_decode",
181 "//ppapi/examples/video_effects", 181 "//ppapi/examples/video_effects",
182 "//ppapi/examples/video_encode", 182 "//ppapi/examples/video_encode",
183 "//printing:printing_unittests", 183 "//printing:printing_unittests",
184 "//sync/tools:sync_client",
brettw 2016/05/23 22:06:25 Moved from below (compiled on more target types no
185 "//sync/tools:sync_listen_notifications",
184 "//third_party/cacheinvalidation:cacheinvalidation_unittests", 186 "//third_party/cacheinvalidation:cacheinvalidation_unittests",
185 "//third_party/codesighs", 187 "//third_party/codesighs",
186 "//third_party/pdfium/samples:pdfium_test", 188 "//third_party/pdfium/samples:pdfium_test",
187 "//tools/battor_agent", 189 "//tools/battor_agent",
188 "//tools/battor_agent:battor_agent_unittests", 190 "//tools/battor_agent:battor_agent_unittests",
189 "//tools/gn", 191 "//tools/gn",
190 "//tools/gn:gn_unittests", 192 "//tools/gn:gn_unittests",
191 "//tools/perf/clear_system_cache", 193 "//tools/perf/clear_system_cache",
192 "//ui/accessibility:accessibility_unittests", 194 "//ui/accessibility:accessibility_unittests",
193 ] 195 ]
(...skipping 328 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 524
523 if (!is_android) { 525 if (!is_android) {
524 deps += [ 526 deps += [
525 "//build/sanitizers:copy_llvm_symbolizer", 527 "//build/sanitizers:copy_llvm_symbolizer",
526 "//chrome/test:chrome_app_unittests", 528 "//chrome/test:chrome_app_unittests",
527 "//gpu/khronos_glcts_support:khronos_glcts_test", 529 "//gpu/khronos_glcts_support:khronos_glcts_test",
528 "//media/cast:cast_benchmarks", 530 "//media/cast:cast_benchmarks",
529 "//media/cast:tap_proxy", 531 "//media/cast:tap_proxy",
530 "//skia:filter_fuzz_stub", 532 "//skia:filter_fuzz_stub",
531 "//skia:image_operations_bench", 533 "//skia:image_operations_bench",
532 "//sync/tools:sync_client",
533 "//sync/tools:sync_listen_notifications",
534 "//third_party/sqlite:sqlite_shell", 534 "//third_party/sqlite:sqlite_shell",
535 "//ui/keyboard:keyboard_unittests", 535 "//ui/keyboard:keyboard_unittests",
536 "//ui/message_center:message_center_unittests", 536 "//ui/message_center:message_center_unittests",
537 "//ui/snapshot:snapshot_unittests", 537 "//ui/snapshot:snapshot_unittests",
538 "//ui/views/examples:views_examples_with_content_exe", 538 "//ui/views/examples:views_examples_with_content_exe",
539 ] 539 ]
540 540
541 if (!is_debug && !is_component_build) { 541 if (!is_debug && !is_component_build) {
542 deps += [ "//chrome/tools/service_discovery_sniffer" ] 542 deps += [ "//chrome/tools/service_discovery_sniffer" ]
543 } 543 }
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 "//media/mojo:tests", 783 "//media/mojo:tests",
784 "//media/mojo/services", 784 "//media/mojo/services",
785 "//mojo:tests", 785 "//mojo:tests",
786 ] 786 ]
787 } 787 }
788 } 788 }
789 789
790 group("gn_visibility") { 790 group("gn_visibility") {
791 deps = [ 791 deps = [
792 "//build/config/sanitizers:options_sources", 792 "//build/config/sanitizers:options_sources",
793
794 # "//third_party/pdfium:pdfium_embeddertests", # TODO(GYP): visibility? 793 # "//third_party/pdfium:pdfium_embeddertests", # TODO(GYP): visibility?
795 # "//third_party/pdfium:pdfium_unittests", # TODO(GYP): visibility? 794 # "//third_party/pdfium:pdfium_unittests", # TODO(GYP): visibility?
796
797 "//ui/resources:repack_ui_test_mac_locale_pack",
brettw 2016/05/23 22:06:25 This is referenced organically now so this referen
798 ] 795 ]
799 796
800 if (!is_ios) { 797 if (!is_ios) {
801 deps += [ 798 deps += [
802 "//v8:postmortem-metadata", 799 "//v8:postmortem-metadata",
803 "//v8:v8_snapshot", 800 "//v8:v8_snapshot",
804 ] 801 ]
805 } 802 }
806 } 803 }
807 804
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
948 assert(target_name != "") # Mark as used. 945 assert(target_name != "") # Mark as used.
949 sources = invoker.actual_sources 946 sources = invoker.actual_sources
950 assert( 947 assert(
951 sources == invoker.actual_sources, 948 sources == invoker.actual_sources,
952 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 949 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
953 } 950 }
954 951
955 assert_valid_out_dir("_unused") { 952 assert_valid_out_dir("_unused") {
956 actual_sources = [ "$root_build_dir/foo" ] 953 actual_sources = [ "$root_build_dir/foo" ]
957 } 954 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | sync/tools/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698