Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: third_party/WebKit/Source/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("config.gni") 5 import("config.gni")
6 if (is_clang) { 6 if (is_clang) {
7 import("//build/config/clang/clang.gni") 7 import("//build/config/clang/clang.gni")
8 } 8 }
9 9
10 visibility = [ "//third_party/WebKit/*" ] 10 visibility = [ "//third_party/WebKit/*" ]
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 ] 74 ]
75 } 75 }
76 76
77 cflags += [ 77 cflags += [
78 "-Xclang", 78 "-Xclang",
79 "-add-plugin", 79 "-add-plugin",
80 "-Xclang", 80 "-Xclang",
81 "blink-gc-plugin", 81 "blink-gc-plugin",
82 ] 82 ]
83 } 83 }
84
85 ## TODO(GYP) : gn does not yet support use_system_icu.
brettw 2016/05/23 22:06:26 use_system_icu isn't required, and if we add it it
86 #if (use_system_icu) {
87 # defines += [ "USING_SYSTEM_ICU" ]
88 #}
89 } 84 }
90 85
91 # The follow configs apply to all targets except for unit tests, which rely on 86 # The follow configs apply to all targets except for unit tests, which rely on
92 # static initializers. 87 # static initializers.
93 config("non_test_config") { 88 config("non_test_config") {
94 cflags = [] 89 cflags = []
95 90
96 if (is_clang) { 91 if (is_clang) {
97 cflags += [ "-Wglobal-constructors" ] 92 cflags += [ "-Wglobal-constructors" ]
98 } 93 }
99 } 94 }
100 95
101 if (is_mac) { 96 if (is_mac) {
102 # This sets up precompiled headers for Mac. 97 # This sets up precompiled headers for Mac.
103 config("mac_precompiled_headers") { 98 config("mac_precompiled_headers") {
104 precompiled_header = rebase_path("build/mac/Prefix.h", root_build_dir) 99 precompiled_header = rebase_path("build/mac/Prefix.h", root_build_dir)
105 precompiled_source = "//third_party/WebKit/Source/build/mac/Prefix.h" 100 precompiled_source = "//third_party/WebKit/Source/build/mac/Prefix.h"
106 } 101 }
107 } 102 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698