Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: testing/test.gni

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/tools/BUILD.gn ('k') | third_party/WebKit/Source/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test.gni
diff --git a/testing/test.gni b/testing/test.gni
index c01306c644880a3b574cda10aec1445640e51451..78a8a37ede4a2ea6e5898939448b6d7c33a0cd12 100644
--- a/testing/test.gni
+++ b/testing/test.gni
@@ -260,7 +260,7 @@ template("test") {
}
}
- # TODO(GYP): Delete this after we've converted everything to GN.
+ # TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility w/ GYP.
group("${target_name}_apk_run") {
testonly = true
@@ -288,8 +288,8 @@ template("test") {
}
ios_app_bundle(_test_target) {
- # TODO(GYP): Make this configurable and only provide a default
- # that can be overridden.
+ # TODO: Make this configurable and only provide a default that can be
+ # overridden.
info_plist = "//testing/gtest_ios/unittest-Info.plist"
app_name = target_name
entitlements_path = "//testing/gtest_ios"
@@ -329,7 +329,7 @@ template("test") {
]
}
- # TODO(GYP): Delete this after we've converted everything to GN.
+ # TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility with GYP.
group("${target_name}_run") {
testonly = true
« no previous file with comments | « sync/tools/BUILD.gn ('k') | third_party/WebKit/Source/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698