Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: third_party/libjingle/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/cacheinvalidation/BUILD.gn ('k') | ui/app_list/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libjingle/BUILD.gn
diff --git a/third_party/libjingle/BUILD.gn b/third_party/libjingle/BUILD.gn
index 8c6acfdd82df1b5228b18a05afca3eb1c558c423..c019fa553d0ec398cfa614d47a0f81021510cfd1 100644
--- a/third_party/libjingle/BUILD.gn
+++ b/third_party/libjingle/BUILD.gn
@@ -54,7 +54,6 @@ config("jingle_public_configs") {
"NO_SOUND_SYSTEM",
]
- # TODO(GYP): Port is_win blocks.
if (is_linux) {
defines += [
"LINUX",
@@ -83,17 +82,6 @@ config("jingle_public_configs") {
if (is_posix) {
defines += [ "WEBRTC_POSIX" ]
}
-
- # TODO(GYP): Support these in GN.
- # if (is_bsd) {
- # defines += [ "BSD" ]
- # }
- # if (is_openbsd) {
- # defines += [ "OPENBSD" ]
- # }
- # if (is_freebsd) {
- # defines += [ "FREEBSD" ]
- # }
if (is_chromeos) {
defines += [ "CHROMEOS" ]
}
@@ -436,4 +424,3 @@ if (enable_webrtc) {
]
}
} # enable_webrtc
-# TODO(GYP): Port libjingle.gyp's enable_webrtc condition block.
« no previous file with comments | « third_party/cacheinvalidation/BUILD.gn ('k') | ui/app_list/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698