Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index ad3070b1374a864b87eb9a4eae8b940d188ab32b..8cd45da88b93b189ce4dcc1160eba717b0b3fb6d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -181,6 +181,8 @@ group("both_gn_and_gyp") {
"//ppapi/examples/video_effects",
"//ppapi/examples/video_encode",
"//printing:printing_unittests",
+ "//sync/tools:sync_client",
+ "//sync/tools:sync_listen_notifications",
"//third_party/cacheinvalidation:cacheinvalidation_unittests",
"//third_party/codesighs",
"//third_party/pdfium/samples:pdfium_test",
@@ -529,8 +531,6 @@ group("both_gn_and_gyp") {
"//media/cast:tap_proxy",
"//skia:filter_fuzz_stub",
"//skia:image_operations_bench",
- "//sync/tools:sync_client",
- "//sync/tools:sync_listen_notifications",
"//third_party/sqlite:sqlite_shell",
"//ui/keyboard:keyboard_unittests",
"//ui/message_center:message_center_unittests",
@@ -790,11 +790,8 @@ group("gn_mojo_targets") {
group("gn_visibility") {
deps = [
"//build/config/sanitizers:options_sources",
-
# "//third_party/pdfium:pdfium_embeddertests", # TODO(GYP): visibility?
# "//third_party/pdfium:pdfium_unittests", # TODO(GYP): visibility?
-
- "//ui/resources:repack_ui_test_mac_locale_pack",
]
if (!is_ios) {
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698