Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: third_party/libjingle/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 6
7 # From third_party/libjingle/libjingle.gyp's target_defaults. 7 # From third_party/libjingle/libjingle.gyp's target_defaults.
8 config("jingle_unexported_configs") { 8 config("jingle_unexported_configs") {
9 defines = [ 9 defines = [
10 "EXPAT_RELATIVE_PATH", 10 "EXPAT_RELATIVE_PATH",
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 ] 47 ]
48 defines = [ 48 defines = [
49 "FEATURE_ENABLE_SSL", 49 "FEATURE_ENABLE_SSL",
50 "FEATURE_ENABLE_VOICEMAIL", 50 "FEATURE_ENABLE_VOICEMAIL",
51 "EXPAT_RELATIVE_PATH", 51 "EXPAT_RELATIVE_PATH",
52 "GTEST_RELATIVE_PATH", 52 "GTEST_RELATIVE_PATH",
53 "NO_MAIN_THREAD_WRAPPING", 53 "NO_MAIN_THREAD_WRAPPING",
54 "NO_SOUND_SYSTEM", 54 "NO_SOUND_SYSTEM",
55 ] 55 ]
56 56
57 # TODO(GYP): Port is_win blocks.
brettw 2016/05/23 22:06:26 The only missing Windows block disables some warni
58 if (is_linux) { 57 if (is_linux) {
59 defines += [ 58 defines += [
60 "LINUX", 59 "LINUX",
61 "WEBRTC_LINUX", 60 "WEBRTC_LINUX",
62 ] 61 ]
63 } 62 }
64 if (is_mac) { 63 if (is_mac) {
65 defines += [ 64 defines += [
66 "OSX", 65 "OSX",
67 "WEBRTC_MAC", 66 "WEBRTC_MAC",
68 ] 67 ]
69 } 68 }
70 if (is_ios) { 69 if (is_ios) {
71 defines += [ 70 defines += [
72 "IOS", 71 "IOS",
73 "WEBRTC_MAC", 72 "WEBRTC_MAC",
74 "WEBRTC_IOS", 73 "WEBRTC_IOS",
75 ] 74 ]
76 } 75 }
77 if (is_win) { 76 if (is_win) {
78 defines += [ "WEBRTC_WIN" ] 77 defines += [ "WEBRTC_WIN" ]
79 } 78 }
80 if (is_android) { 79 if (is_android) {
81 defines += [ "ANDROID" ] 80 defines += [ "ANDROID" ]
82 } 81 }
83 if (is_posix) { 82 if (is_posix) {
84 defines += [ "WEBRTC_POSIX" ] 83 defines += [ "WEBRTC_POSIX" ]
85 } 84 }
86
87 # TODO(GYP): Support these in GN.
88 # if (is_bsd) {
89 # defines += [ "BSD" ]
90 # }
91 # if (is_openbsd) {
92 # defines += [ "OPENBSD" ]
93 # }
94 # if (is_freebsd) {
95 # defines += [ "FREEBSD" ]
96 # }
97 if (is_chromeos) { 85 if (is_chromeos) {
98 defines += [ "CHROMEOS" ] 86 defines += [ "CHROMEOS" ]
99 } 87 }
100 } 88 }
101 89
102 # From third_party/libjingle/libjingle.gyp's target_defaults. 90 # From third_party/libjingle/libjingle.gyp's target_defaults.
103 group("jingle_deps") { 91 group("jingle_deps") {
104 public_deps = [ 92 public_deps = [
105 "//third_party/expat", 93 "//third_party/expat",
106 ] 94 ]
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 sources = [ 417 sources = [
430 "$p2p_dir/stunprober/stunprober.cc", 418 "$p2p_dir/stunprober/stunprober.cc",
431 ] 419 ]
432 420
433 deps = [ 421 deps = [
434 ":libjingle_webrtc_common", 422 ":libjingle_webrtc_common",
435 "//third_party/webrtc/base:rtc_base", 423 "//third_party/webrtc/base:rtc_base",
436 ] 424 ]
437 } 425 }
438 } # enable_webrtc 426 } # enable_webrtc
439 # TODO(GYP): Port libjingle.gyp's enable_webrtc condition block.
brettw 2016/05/23 22:06:26 This is the block above.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698