Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: ui/app_list/BUILD.gn

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libjingle/BUILD.gn ('k') | ui/gl/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/BUILD.gn
diff --git a/ui/app_list/BUILD.gn b/ui/app_list/BUILD.gn
index f6d1ec67ff19d3091f16ee5cef6669681575ae2d..98186d4337154e81d0ae0fa0af1e30cd6326c6a9 100644
--- a/ui/app_list/BUILD.gn
+++ b/ui/app_list/BUILD.gn
@@ -231,42 +231,39 @@ static_library("test_support") {
]
}
-if (is_linux && !is_chromeos) {
- # TODO(GYP): Figure out which of these work and are needed on other platforms.
- if (toolkit_views) {
- executable("app_list_demo") {
- testonly = true
+if (toolkit_views) {
+ executable("app_list_demo") {
+ testonly = true
- sources = [
- "demo/app_list_demo_views.cc",
- ]
+ sources = [
+ "demo/app_list_demo_views.cc",
+ ]
- deps = [
- ":app_list",
- ":test_support",
- "//base",
- "//build/config/sanitizers:deps",
- "//content",
- "//content/public/browser",
- "//skia",
- "//ui/base",
- "//ui/events",
- "//ui/resources",
- "//ui/resources:ui_test_pak",
- "//ui/views",
- "//ui/views/controls/webview",
- "//ui/views_content_client",
- "//url",
- ]
- if (is_win) {
- configs -= [ "//build/config/win:console" ]
- configs += [ "//build/config/win:windowed" ]
+ deps = [
+ ":app_list",
+ ":test_support",
+ "//base",
+ "//build/config/sanitizers:deps",
+ "//content",
+ "//content/public/browser",
+ "//skia",
+ "//ui/base",
+ "//ui/events",
+ "//ui/resources",
+ "//ui/resources:ui_test_pak",
+ "//ui/views",
+ "//ui/views/controls/webview",
+ "//ui/views_content_client",
+ "//url",
+ ]
+ if (is_win) {
+ configs -= [ "//build/config/win:console" ]
+ configs += [ "//build/config/win:windowed" ]
- deps += [
- "//content:sandbox_helper_win",
- "//sandbox",
- ]
- }
+ deps += [
+ "//content:sandbox_helper_win",
+ "//sandbox",
+ ]
}
}
}
« no previous file with comments | « third_party/libjingle/BUILD.gn ('k') | ui/gl/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698