SurfaceAggregator should check whether output is secure when drawin

SurfaceAggregator should check whether output is secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.

BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0c1bf2113c63491c9ebbe78f6dc45e184562c545
Cr-Commit-Position: refs/heads/master@{#394827}

[jbauman, 2016-05-12 02:52:36]

Description was changed from

==========
Have SurfaceAggregator do check for secure output only textures.

BUG=
==========

to

==========
Have SurfaceAggregator do check for secure output only textures.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbauman, 2016-05-17 15:37:48]

Description was changed from

==========
Have SurfaceAggregator do check for secure output only textures.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
SurfaceAggregator should check whether textures are secure when drawing.

Currently the ui::Compositor checks whether the output is secure and whether
there's a copy output request on it before drawing a secure_output_only texture.
This is insufficient, because there may be a copy output request on the final
Surface and the compositor won't know about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbauman, 2016-05-17 15:39:22]

Description was changed from

==========
SurfaceAggregator should check whether textures are secure when drawing.

Currently the ui::Compositor checks whether the output is secure and whether
there's a copy output request on it before drawing a secure_output_only texture.
This is insufficient, because there may be a copy output request on the final
Surface and the compositor won't know about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
SurfaceAggregator should check whether textures are secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbauman, 2016-05-17 15:40:10]

Description was changed from

==========
SurfaceAggregator should check whether textures are secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
SurfaceAggregator should check whether output is secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbauman, 2016-05-17 15:40:20]

jbauman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2016-05-17 19:59:31]

lgtm

https://codereview.chromium.org/1968363002/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host.cc (left):

https://codereview.chromium.org/1968363002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host.cc:662: void LayerTreeHost::SetOutputIsSecure(bool
output_is_secure) {
nit: also remove from header.

[jbauman, 2016-05-18 19:35:04]

jbauman@chromium.org changed reviewers:
+ sky@chromium.org

[jbauman, 2016-05-18 19:35:05]

sky: ash/, components/mus, mojo/ and ui/views OWNERS reviews, please.

[sky, 2016-05-18 21:17:15]

LGTM

[jbauman, 2016-05-18 22:01:56]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-05-18 22:01:57]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1968363002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-05-18 22:02:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968363002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968363002/140001

[commit-bot: I haz the power, 2016-05-18 22:07:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 22:07:47]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbauman, 2016-05-19 17:47:56]

jbauman@chromium.org changed reviewers:
+ dcheng@chromium.org

[jbauman, 2016-05-19 17:47:57]

dcheng: cc/ipc/ OWNERS review

[dcheng, 2016-05-19 17:58:37]

ipc lgtm

[jbauman, 2016-05-19 18:31:58]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-05-19 18:31:58]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1968363002/#ps180001
(title: " ")

[commit-bot: I haz the power, 2016-05-19 18:32:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968363002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968363002/180001

[commit-bot: I haz the power, 2016-05-19 19:20:17]

Description was changed from

==========
SurfaceAggregator should check whether output is secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
SurfaceAggregator should check whether output is secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-19 19:20:19]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-05-19 19:21:52]

Description was changed from

==========
SurfaceAggregator should check whether output is secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.


BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
SurfaceAggregator should check whether output is secure when drawing.

Currently the ui::Compositor checks whether the output is secure and
whether there's a copy output request on it before drawing a
secure_output_only texture. This is insufficient, because there may be a
copy output request on the final Surface and the compositor won't know
about it.

Instead pass that information through the TextureDrawQuad and allow the
SurfaceAggregator to check it.

BUG=610086
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0c1bf2113c63491c9ebbe78f6dc45e184562c545
Cr-Commit-Position: refs/heads/master@{#394827}
==========

[commit-bot: I haz the power, 2016-05-19 19:21:54]

Patchset 10 (id:??) landed as
https://crrev.com/0c1bf2113c63491c9ebbe78f6dc45e184562c545
Cr-Commit-Position: refs/heads/master@{#394827}