Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed)

Created:
4 years, 7 months ago by fmeawad
Modified:
3 years, 11 months ago
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, gavinp+loader_chromium.org, harkness+watch_chromium.org, hongchan, Nate Chapin, jchaffraix+rendering, johnme+watch_chromium.org, jshin+watch_chromium.org, Justin Novosad, kinuko+fileapi, leviw+renderwatch, loading-reviews_chromium.org, mcasas+watch+mediastream_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, nhiroki, ortuno+watch_chromium.org, pdr+renderingwatchlist_chromium.org, Peter Beverloo, philipj_slow, rwlbuis, Raymond Toy, scheib+watch_chromium.org, sof, szager+layoutwatch_chromium.org, tommyw+watchlist_chromium.org, toyoshim+midi_chromium.org, tyoshino+watch_chromium.org, tzik, yhirano+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (patchset #4 id:60001 of https://codereview.chromium.org/1878463002/ ) Reason for revert: This CL causes a clankium crash on the perf waterfall. Attempting a revert. BUG=610015 Original issue's description: > Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. > > Thereby having all ScriptWrappable-derived types on the Oilpan heap. > > R=haraken,tkent,ortuno > BUG=585328 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Committed: https://crrev.com/bf1c0ddd52de2e9b656b8e73bdb7634eb3343fe3 > Cr-Commit-Position: refs/heads/master@{#386347} TBR=tkent@chromium.org,haraken@chromium.org,oilpan-reviews@chromium.org,ortuno@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585328

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -549 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 6 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/WebGLAny.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/WebGLAny.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h View 6 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.cpp View 9 chunks +20 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ArrayBuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ArrayBufferView.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBuffer.h View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBuffer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferBase.h View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBufferView.h View 4 chunks +16 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayPiece.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMDataView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMDataView.cpp View 3 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.h View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DataView.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/FlexibleArrayBufferView.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SharedArrayBuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderSync.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.h View 3 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 5 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 2 chunks +9 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/Shape.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/BeaconLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/BeaconLoader.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/streams/ReadableStreamImpl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 5 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/encoding/TextEncoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encoding/TextEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaEncryptedEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaEncryptedEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 10 chunks +14 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoaderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.h View 4 chunks +22 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 7 chunks +19 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushMessageData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushSubscription.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.h View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.h View 3 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp View 7 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 4 chunks +23 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 10 chunks +9 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 6 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInTransferResult.h View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h View 1 chunk +11 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.h View 2 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebArrayBuffer.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebArrayBufferConverter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebArrayBufferView.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPepperSocketImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebArrayBuffer.h View 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebArrayBufferView.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fmeawad
Created Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.
4 years, 7 months ago (2016-05-11 16:52:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964183004/1
4 years, 7 months ago (2016-05-11 16:53:18 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/168376) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 7 months ago (2016-05-11 16:56:39 UTC) #4
haraken
4 years, 7 months ago (2016-05-11 23:33:07 UTC) #5
This is an old, non-trivial CL. I'd prefer fixing the crash rather than
reverting.

Powered by Google App Engine
This is Rietveld 408576698