third_party/WebKit/Source/modules/push_messaging/PushSubscription.h - Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

index be6fd12d02eaa0cd743d79021dcd2460cbe0f75a..02df6adff6edfc9face37dc36d91a461f8686c75 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h

@@ -31,7 +31,7 @@

KURL endpoint() const;

- DOMArrayBuffer* getKey(const AtomicString& name) const;

+ PassRefPtr<DOMArrayBuffer> getKey(const AtomicString& name) const;

ScriptPromise unsubscribe(ScriptState*);

ScriptValue toJSONForBinding(ScriptState*);

@@ -43,8 +43,8 @@

KURL m_endpoint;

- Member<DOMArrayBuffer> m_p256dh;

- Member<DOMArrayBuffer> m_auth;

+ RefPtr<DOMArrayBuffer> m_p256dh;

+ RefPtr<DOMArrayBuffer> m_auth;

Member<ServiceWorkerRegistration> m_serviceWorkerRegistration;

};