third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h - Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp ('k') | third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

index f80cc690828f94a0130c5dec18e7508f0ea6925b..24599611935ba6bfb9461b72d0ed9a388618d4f7 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

+++ b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

@@ -92,7 +92,7 @@

DOMFloat32Array* curve() { return m_curve.get(); }

private:

- ParamEvent(Type type, float value, double time, double timeConstant, double duration, DOMFloat32Array* curve)

+ ParamEvent(Type type, float value, double time, double timeConstant, double duration, PassRefPtr<DOMFloat32Array> curve)

: m_type(type)

, m_value(value)

, m_time(time)

@@ -109,7 +109,7 @@

double m_timeConstant;

// Only used for SetValueCurve events.

double m_duration;

- CrossThreadPersistent<DOMFloat32Array> m_curve;

+ RefPtr<DOMFloat32Array> m_curve;

};

void insertEvent(const ParamEvent&, ExceptionState&);