third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp - Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp ('k') | third_party/WebKit/Source/modules/encoding/TextEncoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

diff --git a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

index 862b4942250b02621b6e09a06f1e69daa8ed5be2..b2a2195cf35a07f862b94cc079b5c4821af565b5 100644

--- a/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

+++ b/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp

@@ -308,7 +308,7 @@

return ok;

}

-bool getUint8Array(const Dictionary& raw, const char* propertyName, DOMUint8Array*& array, const ErrorContext& context, AlgorithmError* error)

+bool getUint8Array(const Dictionary& raw, const char* propertyName, RefPtr<DOMUint8Array>& array, const ErrorContext& context, AlgorithmError* error)

{

if (!DictionaryHelper::get(raw, propertyName, array) || !array) {

setTypeError(context.toString(propertyName, "Missing or not a Uint8Array"), error);

@@ -320,7 +320,7 @@

// Defined by the WebCrypto spec as:

// typedef Uint8Array BigInteger;

-bool getBigInteger(const Dictionary& raw, const char* propertyName, DOMUint8Array*& array, const ErrorContext& context, AlgorithmError* error)

+bool getBigInteger(const Dictionary& raw, const char* propertyName, RefPtr<DOMUint8Array>& array, const ErrorContext& context, AlgorithmError* error)

{

if (!getUint8Array(raw, propertyName, array, context, error))

return false;

@@ -563,7 +563,7 @@

if (!getUint32(raw, "modulusLength", modulusLength, context, error))

return false;

- DOMUint8Array* publicExponent = nullptr;

+ RefPtr<DOMUint8Array> publicExponent;

if (!getBigInteger(raw, "publicExponent", publicExponent, context, error))

return false;