Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h
diff --git a/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h b/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h
index 2a5bb450f8043fc2ec99bff2224ca0daacc83913..7baabc2546d7c84b203768aace63f27b260bf7f0 100644
--- a/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h
+++ b/third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h
@@ -15,30 +15,27 @@
class USBIsochronousInTransferPacket final : public GarbageCollectedFinalized<USBIsochronousInTransferPacket>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static USBIsochronousInTransferPacket* create(const String& status, DOMDataView* data)
+ static USBIsochronousInTransferPacket* create(const String& status, PassRefPtr<DOMDataView> data)
{
return new USBIsochronousInTransferPacket(status, data);
}
- ~USBIsochronousInTransferPacket() {}
-
- String status() const { return m_status; }
- DOMDataView* data() const { return m_data; }
-
- DEFINE_INLINE_TRACE()
- {
- visitor->trace(m_data);
- }
-
-private:
- USBIsochronousInTransferPacket(const String& status, DOMDataView* data)
+ USBIsochronousInTransferPacket(const String& status, PassRefPtr<DOMDataView> data)
: m_status(status)
, m_data(data)
{
}
+ virtual ~USBIsochronousInTransferPacket() {}
+
+ String status() const { return m_status; }
+ PassRefPtr<DOMDataView> data() const { return m_data; }
+
+ DEFINE_INLINE_TRACE() {}
+
+private:
const String m_status;
- const Member<DOMDataView> m_data;
+ const RefPtr<DOMDataView> m_data;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698