Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: third_party/WebKit/Source/core/html/ImageData.h

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/ImageData.h
diff --git a/third_party/WebKit/Source/core/html/ImageData.h b/third_party/WebKit/Source/core/html/ImageData.h
index e400d302d946087646e255cf7136546495d15e77..cac3ed63b156e13778f0a370b5c4449c68fabf06 100644
--- a/third_party/WebKit/Source/core/html/ImageData.h
+++ b/third_party/WebKit/Source/core/html/ImageData.h
@@ -36,6 +36,7 @@
#include "platform/geometry/IntRect.h"
#include "platform/geometry/IntSize.h"
#include "platform/heap/Handle.h"
+#include "wtf/RefPtr.h"
namespace blink {
@@ -46,7 +47,7 @@
DEFINE_WRAPPERTYPEINFO();
public:
static ImageData* create(const IntSize&);
- static ImageData* create(const IntSize&, DOMUint8ClampedArray*);
+ static ImageData* create(const IntSize&, PassRefPtr<DOMUint8ClampedArray>);
static ImageData* create(unsigned width, unsigned height, ExceptionState&);
static ImageData* create(DOMUint8ClampedArray*, unsigned width, ExceptionState&);
static ImageData* create(DOMUint8ClampedArray*, unsigned width, unsigned height, ExceptionState&);
@@ -61,22 +62,19 @@
IntSize bitmapSourceSize() const override { return m_size; }
ScriptPromise createImageBitmap(ScriptState*, EventTarget&, int sx, int sy, int sw, int sh, const ImageBitmapOptions&, ExceptionState&) override;
- DEFINE_INLINE_TRACE()
- {
- visitor->trace(m_data);
- }
+ DEFINE_INLINE_TRACE() { }
void dispose();
v8::Local<v8::Object> associateWithWrapper(v8::Isolate*, const WrapperTypeInfo*, v8::Local<v8::Object> wrapper) override WARN_UNUSED_RETURN;
private:
- ImageData(const IntSize&, DOMUint8ClampedArray*);
+ ImageData(const IntSize&, PassRefPtr<DOMUint8ClampedArray>);
static bool validateConstructorArguments(DOMUint8ClampedArray*, unsigned width, unsigned&, ExceptionState&);
IntSize m_size;
- Member<DOMUint8ClampedArray> m_data;
+ RefPtr<DOMUint8ClampedArray> m_data;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp ('k') | third_party/WebKit/Source/core/html/ImageData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698