third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h - Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

index 98b21d664fb374ad336ecf7d56ad30d1277ceb41..70bb9fc46b0071623649f5ee95b8e390da6f166c 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

@@ -49,7 +49,7 @@

static BluetoothRemoteGATTCharacteristic* take(ScriptPromiseResolver*, PassOwnPtr<WebBluetoothRemoteGATTCharacteristicInit>);

// Save value.

- void setValue(DOMDataView*);

+ void setValue(const PassRefPtr<DOMDataView>&);

// WebBluetoothRemoteGATTCharacteristic interface:

void dispatchCharacteristicValueChanged(const WebVector<uint8_t>&) override;

@@ -76,7 +76,7 @@

String uuid() { return m_webCharacteristic->uuid; }

BluetoothCharacteristicProperties* properties() { return m_properties; }

- DOMDataView* value() const { return m_value; }

+ PassRefPtr<DOMDataView> value() const { return m_value; }

ScriptPromise readValue(ScriptState*);

ScriptPromise writeValue(ScriptState*, const DOMArrayPiece&);

ScriptPromise startNotifications(ScriptState*);

@@ -92,7 +92,7 @@

OwnPtr<WebBluetoothRemoteGATTCharacteristicInit> m_webCharacteristic;

bool m_stopped;

Member<BluetoothCharacteristicProperties> m_properties;

- Member<DOMDataView> m_value;

+ RefPtr<DOMDataView> m_value;

};

} // namespace blink