Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 23 matching lines...) Expand all
34 34
35 namespace blink { 35 namespace blink {
36 36
37 v8::Local<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer, v8::Local<v8::Object> creationContext, v8::Isolate* isolate) 37 v8::Local<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer, v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
38 { 38 {
39 // We no longer use |creationContext| because it's often misused and points 39 // We no longer use |creationContext| because it's often misused and points
40 // to a context faked by user script. 40 // to a context faked by user script.
41 DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext()); 41 DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext());
42 if (!buffer) 42 if (!buffer)
43 return v8::Local<v8::Value>(); 43 return v8::Local<v8::Value>();
44 return toV8(*buffer, isolate->GetCurrentContext()->Global(), isolate); 44 return toV8(PassRefPtr<DOMArrayBuffer>(*buffer), isolate->GetCurrentContext( )->Global(), isolate);
45 } 45 }
46 46
47 WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Local<v8::Value> value, v8::Isolate* isolate) 47 WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Local<v8::Value> value, v8::Isolate* isolate)
48 { 48 {
49 if (!V8ArrayBuffer::hasInstance(value, isolate)) 49 if (!V8ArrayBuffer::hasInstance(value, isolate))
50 return 0; 50 return 0;
51 return new WebArrayBuffer(V8ArrayBuffer::toImpl(value.As<v8::Object>())); 51 return new WebArrayBuffer(V8ArrayBuffer::toImpl(value.As<v8::Object>()));
52 } 52 }
53 53
54 } // namespace blink 54 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebArrayBuffer.cpp ('k') | third_party/WebKit/Source/web/WebArrayBufferView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698