third_party/WebKit/Source/modules/webusb/USBInTransferResult.h - Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBInTransferResult.h

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webusb/USBDevice.cpp ('k') | third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webusb/USBInTransferResult.h

diff --git a/third_party/WebKit/Source/modules/webusb/USBInTransferResult.h b/third_party/WebKit/Source/modules/webusb/USBInTransferResult.h

index ca54b2098fadb5bb496ca35a46ac543106693f05..8f559e6222e1e0a9bfbde37e942c65ed903a094a 100644

--- a/third_party/WebKit/Source/modules/webusb/USBInTransferResult.h

+++ b/third_party/WebKit/Source/modules/webusb/USBInTransferResult.h

@@ -33,16 +33,13 @@

virtual ~USBInTransferResult() { }

String status() const { return m_status; }

- DOMDataView* data() const { return m_data; }

+ PassRefPtr<DOMDataView> data() const { return m_data; }

- DEFINE_INLINE_TRACE()

- {

- visitor->trace(m_data);

- }

+ DEFINE_INLINE_TRACE() { }

private:

const String m_status;

- const Member<DOMDataView> m_data;

+ const RefPtr<DOMDataView> m_data;

};

} // namespace blink