Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp

Issue 1964183004: Revert of Move DOMArrayBuffer, DOMArrayBufferViews and DataView to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 MediaSource::logAndThrowDOMException(exceptionState, InvalidAccessError, ExceptionMessages::indexExceedsMinimumBound("value", end, m_appendWindowStart)) ; 306 MediaSource::logAndThrowDOMException(exceptionState, InvalidAccessError, ExceptionMessages::indexExceedsMinimumBound("value", end, m_appendWindowStart)) ;
307 return; 307 return;
308 } 308 }
309 309
310 m_webSourceBuffer->setAppendWindowEnd(end); 310 m_webSourceBuffer->setAppendWindowEnd(end);
311 311
312 // 5. Update the attribute to the new value. 312 // 5. Update the attribute to the new value.
313 m_appendWindowEnd = end; 313 m_appendWindowEnd = end;
314 } 314 }
315 315
316 void SourceBuffer::appendBuffer(DOMArrayBuffer* data, ExceptionState& exceptionS tate) 316 void SourceBuffer::appendBuffer(PassRefPtr<DOMArrayBuffer> data, ExceptionState& exceptionState)
317 { 317 {
318 WTF_LOG(Media, "SourceBuffer(%p)::appendBuffer size=%u", this, data->byteLen gth()); 318 WTF_LOG(Media, "SourceBuffer(%p)::appendBuffer size=%u", this, data->byteLen gth());
319 // Section 3.2 appendBuffer() 319 // Section 3.2 appendBuffer()
320 // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-sou rce.html#widl-SourceBuffer-appendBuffer-void-ArrayBufferView-data 320 // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-sou rce.html#widl-SourceBuffer-appendBuffer-void-ArrayBufferView-data
321 appendBufferInternal(static_cast<const unsigned char*>(data->data()), data-> byteLength(), exceptionState); 321 appendBufferInternal(static_cast<const unsigned char*>(data->data()), data-> byteLength(), exceptionState);
322 } 322 }
323 323
324 void SourceBuffer::appendBuffer(DOMArrayBufferView* data, ExceptionState& except ionState) 324 void SourceBuffer::appendBuffer(PassRefPtr<DOMArrayBufferView> data, ExceptionSt ate& exceptionState)
325 { 325 {
326 WTF_LOG(Media, "SourceBuffer(%p)::appendBuffer size=%u", this, data->byteLen gth()); 326 WTF_LOG(Media, "SourceBuffer(%p)::appendBuffer size=%u", this, data->byteLen gth());
327 // Section 3.2 appendBuffer() 327 // Section 3.2 appendBuffer()
328 // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-sou rce.html#widl-SourceBuffer-appendBuffer-void-ArrayBufferView-data 328 // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-sou rce.html#widl-SourceBuffer-appendBuffer-void-ArrayBufferView-data
329 appendBufferInternal(static_cast<const unsigned char*>(data->baseAddress()), data->byteLength(), exceptionState); 329 appendBufferInternal(static_cast<const unsigned char*>(data->baseAddress()), data->byteLength(), exceptionState);
330 } 330 }
331 331
332 void SourceBuffer::appendStream(Stream* stream, ExceptionState& exceptionState) 332 void SourceBuffer::appendStream(Stream* stream, ExceptionState& exceptionState)
333 { 333 {
334 m_streamMaxSizeValid = false; 334 m_streamMaxSizeValid = false;
(...skipping 623 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 visitor->trace(m_removeAsyncPartRunner); 958 visitor->trace(m_removeAsyncPartRunner);
959 visitor->trace(m_appendStreamAsyncPartRunner); 959 visitor->trace(m_appendStreamAsyncPartRunner);
960 visitor->trace(m_stream); 960 visitor->trace(m_stream);
961 visitor->trace(m_audioTracks); 961 visitor->trace(m_audioTracks);
962 visitor->trace(m_videoTracks); 962 visitor->trace(m_videoTracks);
963 RefCountedGarbageCollectedEventTargetWithInlineData<SourceBuffer>::trace(vis itor); 963 RefCountedGarbageCollectedEventTargetWithInlineData<SourceBuffer>::trace(vis itor);
964 ActiveDOMObject::trace(visitor); 964 ActiveDOMObject::trace(visitor);
965 } 965 }
966 966
967 } // namespace blink 967 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698