Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1904773004: Revert of Introduce components/display_compositor (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
CC:
blundell+watchlist_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, droger+watchlist_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, rjkroege, sdefresne+watchlist_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce components/display_compositor (patchset #22 id:410001 of https://codereview.chromium.org/1902463002/ ) Reason for revert: This added the new test to some FYI bots (but nowhere else?) and claimed that the binary can run on swarming but it doesn't add a _run target or an isolate file to actually run it on swarming. As a consequence, the FYI bots this added the test to that still use gyp now all fail their "isolate tests" step. Example: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4976 Original issue's description: > Introduce components/display_compositor > > We would like to share BufferQueue, GLHelper and later other parts > of content/browser/compositor in Mus. This CL introduces a new > display_compositor component and moves BufferQueue, GLHelper and > friends to components/display_compositor. > > BUG=601867 > TBR=ben@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > NOTRY=true > NOTREECHECKS=true TBR=ben@chromium.org,piman@chromium.org,sky@chromium.org,xhwang@chromium.org,tkent@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601867 Committed: https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874 Cr-Commit-Position: refs/heads/master@{#388760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6372 lines, -6776 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/components.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D components/display_compositor.gypi View 1 chunk +0 lines, -102 lines 0 comments Download
D components/display_compositor/BUILD.gn View 1 chunk +0 lines, -101 lines 0 comments Download
D components/display_compositor/DEPS View 1 chunk +0 lines, -17 lines 0 comments Download
D components/display_compositor/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/display_compositor/buffer_queue.h View 1 chunk +0 lines, -126 lines 0 comments Download
D components/display_compositor/buffer_queue.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D components/display_compositor/buffer_queue_unittest.cc View 1 chunk +0 lines, -635 lines 0 comments Download
D components/display_compositor/display_compositor_export.h View 1 chunk +0 lines, -33 lines 0 comments Download
D components/display_compositor/display_compositor_test_suite.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/display_compositor/display_compositor_test_suite.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D components/display_compositor/gl_helper.h View 1 chunk +0 lines, -382 lines 0 comments Download
D components/display_compositor/gl_helper.cc View 1 chunk +0 lines, -1248 lines 0 comments Download
D components/display_compositor/gl_helper_benchmark.cc View 1 chunk +0 lines, -252 lines 0 comments Download
D components/display_compositor/gl_helper_readback_support.h View 1 chunk +0 lines, -76 lines 0 comments Download
D components/display_compositor/gl_helper_readback_support.cc View 1 chunk +0 lines, -172 lines 0 comments Download
D components/display_compositor/gl_helper_scaling.h View 1 chunk +0 lines, -208 lines 0 comments Download
D components/display_compositor/gl_helper_scaling.cc View 1 chunk +0 lines, -881 lines 0 comments Download
D components/display_compositor/gl_helper_unittest.cc View 1 chunk +0 lines, -1437 lines 0 comments Download
D components/display_compositor/run_all_unittests.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D components/display_compositor/yuv_readback_unittest.cc View 1 chunk +0 lines, -554 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A content/browser/compositor/buffer_queue.h View 1 chunk +126 lines, -0 lines 0 comments Download
A content/browser/compositor/buffer_queue.cc View 1 chunk +265 lines, -0 lines 0 comments Download
A content/browser/compositor/buffer_queue_unittest.cc View 1 chunk +630 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper.h View 1 chunk +382 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper.cc View 1 chunk +1237 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper_benchmark.cc View 1 chunk +247 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper_readback_support.h View 1 chunk +75 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper_readback_support.cc View 1 chunk +172 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper_scaling.h View 1 chunk +206 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper_scaling.cc View 1 chunk +881 lines, -0 lines 0 comments Download
A content/browser/compositor/gl_helper_unittest.cc View 1 chunk +1439 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/compositor/image_transport_factory.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/compositor/image_transport_factory_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/owned_mailbox.h View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/compositor/owned_mailbox.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/reflector_texture.h View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/compositor/reflector_texture.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/compositor/surface_utils.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.cc View 3 chunks +5 lines, -6 lines 0 comments Download
A content/browser/compositor/yuv_readback_unittest.cc View 1 chunk +554 lines, -0 lines 0 comments Download
M content/browser/media/capture/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M content/browser/renderer_host/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 2 chunks +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 7 chunks +11 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 5 chunks +28 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 5 chunks +33 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 12 chunks +0 lines, -66 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
Created Revert of Introduce components/display_compositor
4 years, 8 months ago (2016-04-21 13:58:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904773004/1
4 years, 8 months ago (2016-04-21 13:58:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 13:59:52 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:34:17 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b844a929a8e624c6391d5efab8aea49bb883874
Cr-Commit-Position: refs/heads/master@{#388760}

Powered by Google App Engine
This is Rietveld 408576698