Have bindings layer assume and insist that all interface types are GCed.

Have bindings layer assume and insist that all interface types are GCed.

All interface types are now garbage collected, hence assume that to
hold when generating bindings code. Various simplifications become
possible as a result, like removing WrapperTypeInfo fields to per-type
de/refObject() static functions.

At the .idl level, [GarbageCollected] no longer conveys anything hence
the support (and use) for it is retired here also.

R=
BUG=585328
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/026d27a4fd3a2625a5a557fc9833159954b1d4a2
Cr-Commit-Position: refs/heads/master@{#386620}

[sof, 2016-04-11 20:45:51]

Description was changed from

==========
Have bindings layer assume and insist that all interface types are GCed.

All interface types are now garbage collected, hence assume that to
hold when generating bindings code. Various simplifications become
possible as a result, like removing WrapperTypeInfo fields to per-type
de/refObject() static functions.

At the .idl level, [GarbageCollected] no longer conveys anything hence
the support (and use) for it is retired here also.

R=
BUG=585328
==========

to

==========
Have bindings layer assume and insist that all interface types are GCed.

All interface types are now garbage collected, hence assume that to
hold when generating bindings code. Various simplifications become
possible as a result, like removing WrapperTypeInfo fields to per-type
de/refObject() static functions.

At the .idl level, [GarbageCollected] no longer conveys anything hence
the support (and use) for it is retired here also.

R=
BUG=585328
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[sof, 2016-04-11 21:45:46]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-04-11 21:45:50]

please take a look.

Apologies for the size of it; only the first page is of interest though.

[haraken, 2016-04-11 23:38:55]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-04-11 23:38:59]

LGTM, great simplification!

Can we insert a static_assert somewhere (toV8?) to verify that all
ScriptWrappables are GarbageCollected?

https://codereview.chromium.org/1873323002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h (right):

https://codereview.chromium.org/1873323002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h:123: void
refObject() const

I'd rename refObject/derefObject to wrapperCreated/wrapperDestroyed.

[sof, 2016-04-12 06:14:27]

> Can we insert a static_assert somewhere (toV8?) to verify that all
ScriptWrappables are GarbageCollected?

That's a really good idea & place to enforce the constraint; added.

https://codereview.chromium.org/1873323002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h (right):

https://codereview.chromium.org/1873323002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h:123: void
refObject() const
On 2016/04/11 23:38:59, haraken wrote:
> 
> I'd rename refObject/derefObject to wrapperCreated/wrapperDestroyed.

Renamed to the suggested name pair.

[haraken, 2016-04-12 06:30:21]

LGTM

[sof, 2016-04-12 06:36:31]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-04-12 06:36:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873323002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873323002/40001

[commit-bot: I haz the power, 2016-04-12 08:16:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 08:17:13]

Description was changed from

==========
Have bindings layer assume and insist that all interface types are GCed.

All interface types are now garbage collected, hence assume that to
hold when generating bindings code. Various simplifications become
possible as a result, like removing WrapperTypeInfo fields to per-type
de/refObject() static functions.

At the .idl level, [GarbageCollected] no longer conveys anything hence
the support (and use) for it is retired here also.

R=
BUG=585328
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Have bindings layer assume and insist that all interface types are GCed.

All interface types are now garbage collected, hence assume that to
hold when generating bindings code. Various simplifications become
possible as a result, like removing WrapperTypeInfo fields to per-type
de/refObject() static functions.

At the .idl level, [GarbageCollected] no longer conveys anything hence
the support (and use) for it is retired here also.

R=
BUG=585328
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/026d27a4fd3a2625a5a557fc9833159954b1d4a2
Cr-Commit-Position: refs/heads/master@{#386620}
==========

[commit-bot: I haz the power, 2016-04-12 08:17:16]

Patchset 3 (id:??) landed as
https://crrev.com/026d27a4fd3a2625a5a557fc9833159954b1d4a2
Cr-Commit-Position: refs/heads/master@{#386620}