Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
index db1d13a7a61961d9413b1a23eaaba9863151c644..b6d3b1c184cf698cba703b7c722444028a5b0d2b 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h
@@ -141,17 +141,17 @@ public:
void setTestInterfaceGarbageCollectedSequenceMember(const HeapVector<Member<TestInterfaceGarbageCollected>>& value) { m_testInterfaceGarbageCollectedSequenceMember = value; }
bool hasTestInterfaceMember() const { return m_testInterfaceMember; }
- PassRefPtr<TestInterfaceImplementation> testInterfaceMember() const { return m_testInterfaceMember; }
- void setTestInterfaceMember(PassRefPtr<TestInterfaceImplementation> value) { m_testInterfaceMember = value; }
+ TestInterfaceImplementation* testInterfaceMember() const { return m_testInterfaceMember; }
+ void setTestInterfaceMember(TestInterfaceImplementation* value) { m_testInterfaceMember = value; }
bool hasTestInterfaceOrNullMember() const { return m_testInterfaceOrNullMember; }
- PassRefPtr<TestInterfaceImplementation> testInterfaceOrNullMember() const { return m_testInterfaceOrNullMember; }
- void setTestInterfaceOrNullMember(PassRefPtr<TestInterfaceImplementation> value) { m_testInterfaceOrNullMember = value; }
- void setTestInterfaceOrNullMemberToNull() { m_testInterfaceOrNullMember = RefPtr<TestInterfaceImplementation>(); }
+ TestInterfaceImplementation* testInterfaceOrNullMember() const { return m_testInterfaceOrNullMember; }
+ void setTestInterfaceOrNullMember(TestInterfaceImplementation* value) { m_testInterfaceOrNullMember = value; }
+ void setTestInterfaceOrNullMemberToNull() { m_testInterfaceOrNullMember = Member<TestInterfaceImplementation>(); }
bool hasTestInterfaceSequenceMember() const { return !m_testInterfaceSequenceMember.isNull(); }
- const Vector<RefPtr<TestInterfaceImplementation>>& testInterfaceSequenceMember() const { return m_testInterfaceSequenceMember.get(); }
- void setTestInterfaceSequenceMember(const Vector<RefPtr<TestInterfaceImplementation>>& value) { m_testInterfaceSequenceMember = value; }
+ const HeapVector<Member<TestInterfaceImplementation>>& testInterfaceSequenceMember() const { return m_testInterfaceSequenceMember.get(); }
+ void setTestInterfaceSequenceMember(const HeapVector<Member<TestInterfaceImplementation>>& value) { m_testInterfaceSequenceMember = value; }
bool hasUint8ArrayMember() const { return m_uint8ArrayMember; }
DOMUint8Array* uint8ArrayMember() const { return m_uint8ArrayMember; }
@@ -190,9 +190,9 @@ private:
Member<TestInterfaceGarbageCollected> m_testInterfaceGarbageCollectedMember;
Member<TestInterfaceGarbageCollected> m_testInterfaceGarbageCollectedOrNullMember;
Nullable<HeapVector<Member<TestInterfaceGarbageCollected>>> m_testInterfaceGarbageCollectedSequenceMember;
- RefPtr<TestInterfaceImplementation> m_testInterfaceMember;
- RefPtr<TestInterfaceImplementation> m_testInterfaceOrNullMember;
- Nullable<Vector<RefPtr<TestInterfaceImplementation>>> m_testInterfaceSequenceMember;
+ Member<TestInterfaceImplementation> m_testInterfaceMember;
+ Member<TestInterfaceImplementation> m_testInterfaceOrNullMember;
+ Nullable<HeapVector<Member<TestInterfaceImplementation>>> m_testInterfaceSequenceMember;
Member<DOMUint8Array> m_uint8ArrayMember;
Nullable<double> m_unrestrictedDoubleMember;

Powered by Google App Engine
This is Rietveld 408576698