third_party/WebKit/Source/bindings/scripts/v8_utilities.py - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_types.py ('k') | third_party/WebKit/Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

index 183763570ceb21108928d84ef7249b514e7e816e..074377dec71493e539ec102be5b7d4e94cf1c311 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

@@ -185,7 +185,7 @@ def activity_logging_world_check(member):

CALL_WITH_ARGUMENTS = {

'ScriptState': 'scriptState',

'ExecutionContext': 'executionContext',

- 'ScriptArguments': 'scriptArguments.release()',

+ 'ScriptArguments': 'scriptArguments',

'CurrentWindow': 'currentDOMWindow(info.GetIsolate())',

'EnteredWindow': 'enteredDOMWindow(info.GetIsolate())',

'Document': 'document',

@@ -324,14 +324,6 @@ def exposed(member, interface):

return exposure_set.code()

-# [GarbageCollected]

-def gc_type(definition):

- extended_attributes = definition.extended_attributes

- if 'GarbageCollected' in extended_attributes:

- return 'GarbageCollectedObject'

- return 'RefCountedObject'

# [ImplementedAs]

def cpp_name(definition_or_member):

extended_attributes = definition_or_member.extended_attributes