third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp

index de17ded23fac3dfabc2335f74e22a60de002bd6a..5c24116bf0a36b7d9cedc36b4abd4031844a4e8a 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp

@@ -19,7 +19,7 @@ TestDictionary::TestDictionary()

setStringOrNullMember(String("default string value"));

setStringSequenceMember(Vector<String>());

setTestInterfaceGarbageCollectedSequenceMember(HeapVector<Member<TestInterfaceGarbageCollected>>());

- setTestInterfaceSequenceMember(Vector<RefPtr<TestInterfaceImplementation>>());

+ setTestInterfaceSequenceMember(HeapVector<Member<TestInterfaceImplementation>>());

setUnrestrictedDoubleMember(3.14);

}

@@ -39,6 +39,9 @@ DEFINE_TRACE(TestDictionary)

visitor->trace(m_testInterfaceGarbageCollectedMember);

visitor->trace(m_testInterfaceGarbageCollectedOrNullMember);

visitor->trace(m_testInterfaceGarbageCollectedSequenceMember);

+ visitor->trace(m_testInterfaceMember);

+ visitor->trace(m_testInterfaceOrNullMember);

+ visitor->trace(m_testInterfaceSequenceMember);

visitor->trace(m_uint8ArrayMember);

}