third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushMessageData.idl ('k') | third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://w3c.github.io/push-api/#pushsubscription-interface	5 // https://w3c.github.io/push-api/#pushsubscription-interface

6	6

7 enum PushEncryptionKeyName {	7 enum PushEncryptionKeyName {

8 "p256dh",	8 "p256dh",

9 "auth"	9 "auth"

10 };	10 };

11	11

12 [	12 [

13 Exposed=(Window,ServiceWorker),	13 Exposed=(Window,ServiceWorker),

14 GarbageCollected,

15 RuntimeEnabled=PushMessaging,	14 RuntimeEnabled=PushMessaging,

16 ] interface PushSubscription {	15 ] interface PushSubscription {

17 readonly attribute USVString endpoint;	16 readonly attribute USVString endpoint;

18	17

19 [RuntimeEnabled=PushMessagingData] ArrayBuffer? getKey(PushEncryptionKeyName name);	18 [RuntimeEnabled=PushMessagingData] ArrayBuffer? getKey(PushEncryptionKeyName name);

20 [CallWith=ScriptState] Promise<boolean> unsubscribe();	19 [CallWith=ScriptState] Promise<boolean> unsubscribe();

21	20

22 serializer;	21 serializer;

23 };	22 };

OLD	NEW