Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp b/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
index fc91bc5cdf2c10cf1637f243e8bc7cadc187f20a..d43dc0d2266721335d1765da5ecacee27f56d72e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
@@ -7,7 +7,6 @@
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8BindingForTesting.h"
#include "core/testing/GarbageCollectedScriptWrappable.h"
-#include "core/testing/RefCountedScriptWrappable.h"
#include "platform/heap/Heap.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "wtf/Vector.h"
@@ -61,21 +60,6 @@ public:
Persistent<GarbageCollectedScriptWrappable> m_scriptWrappable;
};
-TEST_F(ToV8Test, refCountedScriptWrappable)
-{
- RefPtr<RefCountedScriptWrappable> object = RefCountedScriptWrappable::create("hello");
-
- TEST_TOV8("hello", object);
- TEST_TOV8("hello", object.get());
- TEST_TOV8("hello", object.release());
-
- ASSERT_FALSE(object);
-
- TEST_TOV8("null", object);
- TEST_TOV8("null", object.get());
- TEST_TOV8("null", object.release());
-}
-
TEST_F(ToV8Test, garbageCollectedScriptWrappable)
{
GarbageCollectedScriptWrappable* object = new GarbageCollectedScriptWrappable("world");
@@ -166,15 +150,6 @@ TEST_F(ToV8Test, scriptValue)
TEST_TOV8("1234", value);
}
-TEST_F(ToV8Test, vector)
-{
- Vector<RefPtr<RefCountedScriptWrappable>> v;
- v.append(RefCountedScriptWrappable::create("foo"));
- v.append(RefCountedScriptWrappable::create("bar"));
-
- TEST_TOV8("foo,bar", v);
-}
-
TEST_F(ToV8Test, stringVectors)
{
Vector<String> stringVector;

Powered by Google App Engine
This is Rietveld 408576698