third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h

index 0ec969815279792a938fe6bb70797f92ca1cb170..f60ff84b82c1de3ed1f6c9ae5f3e5693f109a810 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.h

@@ -30,11 +30,10 @@ public:

}

CORE_EXPORT static TestInterfaceConstructor4* toImplWithTypeCheck(v8::Isolate*, v8::Local<v8::Value>);

CORE_EXPORT static const WrapperTypeInfo wrapperTypeInfo;

- static void refObject(ScriptWrappable*);

- static void derefObject(ScriptWrappable*);

template<typename VisitorDispatcher>

static void trace(VisitorDispatcher visitor, ScriptWrappable* scriptWrappable)

{

+ visitor->trace(scriptWrappable->toImpl<TestInterfaceConstructor4>());

}

static void constructorCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;