third_party/WebKit/Source/bindings/templates/interface.h - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.h

diff --git a/third_party/WebKit/Source/bindings/templates/interface.h b/third_party/WebKit/Source/bindings/templates/interface.h

index bfc651b182261d5147bf9932db0ec15437a6f2ec..b1ee90bd880b95b370745fd5869456717e40f306 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.h

+++ b/third_party/WebKit/Source/bindings/templates/interface.h

@@ -59,14 +59,10 @@ public:

{% else %}

{{exported}}static const WrapperTypeInfo wrapperTypeInfo;

{% endif %}

- static void refObject(ScriptWrappable*);

- static void derefObject(ScriptWrappable*);

template<typename VisitorDispatcher>

static void trace(VisitorDispatcher visitor, ScriptWrappable* scriptWrappable)

{

- {% if gc_type == 'GarbageCollectedObject' %}

visitor->trace(scriptWrappable->toImpl<{{cpp_class}}>());

- {% endif %}

}

{% if has_visit_dom_wrapper %}

static void visitDOMWrapper(v8::Isolate*, ScriptWrappable*, const v8::Persistent<v8::Object>&);