third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/Credential.idl ('k') | third_party/WebKit/Source/modules/crypto/Crypto.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl

index dc7c1097bcea6a58ba6fc165326c28b0556dd085..80d59480a7286f903afa53674d24b2b606d4fd5b 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.idl

@@ -4,7 +4,6 @@

[

RuntimeEnabled=CredentialManager,

- GarbageCollected

] interface CredentialsContainer {

[CallWith=ScriptState, MeasureAs=CredentialManagerGet] Promise get(optional CredentialRequestOptions options);

[CallWith=ScriptState, MeasureAs=CredentialManagerStore] Promise store(Credential credential);