third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

diff --git a/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py b/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

index 2fa6409d7420b52f6b84d695c97d1e0ce0b79370..1922008cd192777c9e9aa1156a08873aeb1d3497 100644

--- a/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

+++ b/third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py

@@ -202,7 +202,7 @@ def merge_interface_dependencies(definitions, component, target_interface, depen

# cpp class to obtain partial interface's cpp class.

# e.g.. V8WindowPartial.cpp:

# DOMWindow* impl = V8Window::toImpl(holder);

- # RawPtr<...> cppValue(DOMWindowQuota::webkitStorageInfo(impl));

+ # DOMWindowQuota* cppValue(DOMWindowQuota::webkitStorageInfo(impl));

# TODO(tasak): remove ImplementedAs extended attributes

# from all partial interfaces. Instead, rename all cpp/header

# files correctly. ImplementedAs should not be allowed in